-
Notifications
You must be signed in to change notification settings - Fork 61
Closed as not planned
Closed as not planned
Copy link
Labels
Description
Objective
Make table wrapping behavior explicit by adding .Wrap(false) or .Wrap(true) to all table creation calls in the codebase.
Context
From discussion #12479 - Go Fan review of charmbracelet/lipgloss usage.
Since lipgloss v1.1.0, tables wrap content by default. The gh-aw codebase should be explicit about wrapping intent to:
- Prevent layout surprises from default behavior
- Make code intent clearer for maintainers
- Ensure tables render as expected (especially numeric tables)
Approach
- Locate all table creation calls in
pkg/console/console.go(lines 283-289 and similar) - Add explicit
.Wrap(false)for tables that should maintain fixed column width (numeric tables, status tables) - Add explicit
.Wrap(true)for tables where content wrapping is desired (long text descriptions) - Add code comments explaining the wrapping choice
Files to Modify
pkg/console/console.go- Add.Wrap()calls to table creation- Any other files using
lipgloss/table(search fortable.New())
Example
// Before
t := table.New().
Headers(headers...).
Rows(rows...).
Border(styles.RoundedBorder)
// After (for numeric/status tables)
t := table.New().
Headers(headers...).
Rows(rows...).
Border(styles.RoundedBorder).
Wrap(false) // No wrapping for numeric columns
// After (for text tables)
t := table.New().
Headers(headers...).
Rows(rows...).
Border(styles.RoundedBorder).
Wrap(true) // Allow content to wrap in cellsAcceptance Criteria
- All
table.New()calls have explicit.Wrap()configuration - Wrapping choice is documented with code comments
- Tables render correctly in both TTY and non-TTY contexts
- No visual regressions in existing table output
AI generated by Plan Command for discussion #12479
Reactions are currently unavailable