-
Notifications
You must be signed in to change notification settings - Fork 250
Closed
Labels
Description
Objective
Update the $comment field in pkg/parser/schemas/main_workflow_schema.json for the safe-outputs property to include four operations that are fully implemented in Go and documented but are missing from the $comment string.
Context
Discussion #17442 identified that the $comment field for safe-outputs is incomplete. Four operations are fully defined in the schema, implemented in Go, and documented, but are not listed in the $comment.
Missing Operations
The following four operations need to be added to the $comment in pkg/parser/schemas/main_workflow_schema.json at line 3923, within the safe-outputs object:
assign-to-userunassign-from-usercreate-projectmissing-data
File to Modify
- File:
pkg/parser/schemas/main_workflow_schema.json - Line: ~3923 (the
$commentfield under"safe-outputs")
Current $comment Value
"Required if workflow creates or modifies GitHub resources. Operations requiring safe-outputs: autofix-code-scanning-alert, add-comment, add-labels, add-reviewer, assign-milestone, assign-to-agent, close-discussion, close-issue, close-pull-request, create-agent-session, create-agent-task (deprecated, use create-agent-session), create-code-scanning-alert, create-discussion, create-issue, create-project-status-update, create-pull-request, create-pull-request-review-comment, dispatch-workflow, hide-comment, link-sub-issue, mark-pull-request-as-ready-for-review, missing-tool, noop, push-to-pull-request-branch, remove-labels, reply-to-pull-request-review-comment, resolve-pull-request-review-thread, submit-pull-request-review, threat-detection, update-discussion, update-issue, update-project, update-pull-request, update-release, upload-asset. See documentation for complete details."
Expected Change
Add the four missing operations into the alphabetically-appropriate positions in the comma-separated list:
assign-to-user→ afterassign-to-agentcreate-project→ aftercreate-issue(or nearcreate-project-status-update)missing-data→ aftermark-pull-request-as-ready-for-review(beforemissing-tool)unassign-from-user→ afterupdate-release/upload-assetor alphabetically nearupdate-*
Steps
- Open
pkg/parser/schemas/main_workflow_schema.json - Locate the
"safe-outputs"object (around line 3921) - Update the
$commentstring to include all four missing operations in the operations list - Run
make buildto rebuild the binary (schema is embedded via//go:embed) - Run
make agent-finishto validate
Acceptance Criteria
- All four operations (
assign-to-user,unassign-from-user,create-project,missing-data) are present in the$commentfield - The list remains alphabetically ordered or logically grouped
-
make buildsucceeds -
make agent-finishpasses
Generated by Plan Command for issue #discussion #17442
- expires on Feb 23, 2026, 12:10 PM UTC
Reactions are currently unavailable