-
Notifications
You must be signed in to change notification settings - Fork 260
Closed as not planned
Closed as not planned
Copy link
Labels
Description
Objective
Fix SC1003 (single-quote escape syntax) warnings in 23 workflows — 158 total occurrences — by correcting --allow-domains argument string escaping in the compiler or the affected workflow markdown files.
Context
From Static Analysis Report discussion #17668 (2026-02-22 scan):
- 158 SC1003 occurrences across 23 workflows
- SC1003: "This
\'does not look right. Was it supposed to be\'within single-quotes or"'"for concatenation?" - Concentrated in
--allow-domainsargument strings in Playwright tool configurations - Top affected workflows:
typist(20),semantic-function-refactor(12),daily-mcp-concurrency-analysis(12),go-logger(10)
Technical Analysis Needed
First, determine whether the issue is:
- Compiler-generated — the compiler produces incorrect escape sequences in the shell script for
--allow-domainsarguments - Per-workflow markdown — individual workflow frontmatter contains incorrect escaping
Run: grep -n "allow-domains" .github/workflows/typist.lock.yml | head -20 to see the generated shell script.
Steps
- Inspect the generated shell code in one affected lock file (e.g.,
typist.lock.yml) to identify the exact SC1003 pattern - Trace the escaping logic back to the compiler source in
pkg/workflow/— look for whereallow_domains/allowed_domainsvalues are serialized into shell arguments - Fix the escaping logic: either use proper quoting (double-quote the argument) or use correct bash escape sequences
- Run
make recompileto regenerate all lock files - Verify SC1003 is gone:
actionlint .github/workflows/*.lock.yml 2>&1 | grep SC1003 | wc -lshould return 0 - Run
make agent-finishto validate
Acceptance Criteria
- SC1003 no longer appears in any affected workflows
-
--allow-domainsarguments still work correctly at runtime -
make agent-finishpasses
Generated by Plan Command for issue #discussion #17668
- expires on Feb 24, 2026, 7:00 AM UTC
Reactions are currently unavailable