-
Notifications
You must be signed in to change notification settings - Fork 46
Description
✅ Safe-outputs Path Fix VERIFIED - But NEW Issue Discovered: GitHub MCP Docker Failure
Good News! 🎉
The safe-outputs path mismatch from #2357 is FIXED! Commit 835022311824 successfully resolved the path inconsistency.
Evidence of Fix
From run #18797919838 session log:
2025-10-25T04:05:15.031Z [LOG] Starting MCP client for safe_outputs with command: node and args: /tmp/gh-aw/safeoutputs/mcp-server.cjs
...
2025-10-25T04:05:15.071Z [LOG] MCP client for safe_outputs connected, took 39ms
2025-10-25T04:05:15.071Z [LOG] Started MCP client for safe_outputs
...
2025-10-25T04:05:15.745Z [DEBUG] Adding tool: safe_outputs-create_issue
2025-10-25T04:05:15.745Z [DEBUG] Adding tool: safe_outputs-missing_tool
✅ Safe-outputs MCP server:
- Path:
/tmp/gh-aw/safeoutputs/mcp-server.cjs(matches workflow) - Status: Connected successfully in 39ms
- Tools loaded:
create_issue,missing_tool
New Issue Discovered ⚠️
However, the workflow still failed, but for a completely different reason: The GitHub MCP server (Docker-based) is failing to start.
The New Error
2025-10-25T04:05:15.023Z [LOG] Starting MCP client for github with command: docker and args: run,-i,--rm,-e,GITHUB_PERSONAL_ACCESS_TOKEN,ghcr.io/github/github-mcp-server:v0.19.1,--read-only
...
2025-10-25T04:05:15.259Z [LOG] MCP transport for github closed
2025-10-25T04:05:15.260Z [ERROR] Failed to start MCP client for github: McpError: MCP error -32000: Connection closed
2025-10-25T04:05:15.260Z [DEBUG] GitHub MCP server is disabled, skipping auto-configuration
❌ GitHub MCP server:
- Docker command:
docker run -i --rm -e GITHUB_PERSONAL_ACCESS_TOKEN ghcr.io/github/github-mcp-server:v0.19.1 --read-only - Status: Connection closed after 236ms
- Error: MCP error -32000
Impact
- Agent runs but without GitHub MCP tools (GitHub API access via MCP)
- Agent falls back to trying
ghCLI andcurlfor GitHub API access - Both fallbacks fail with "Permission denied" errors
- Agent cannot complete task (reviewing last 5 merged PRs)
- Agent reports needing GitHub API/tools but can't use
missing_tooldue to permissions
Likely Causes
The Docker connection failure after 236ms suggests:
- Docker daemon not available in GitHub Actions runner
- Docker socket permissions preventing container startup
- Network connectivity issue to ghcr.io
- Environment variable
GITHUB_PERSONAL_ACCESS_TOKENnot properly configured - Docker service not running or not accessible
Run Comparison
| Run | Safe-outputs MCP | GitHub MCP | Overall Status |
|---|---|---|---|
| #41 (previous) | ❌ Path mismatch | ❌ Failed (cascading) | Failed |
| #42 (this run) | ✅ Working | ❌ Docker failure | Failed (new issue) |
Recommended Next Steps
Immediate Investigation
-
Check Docker availability in workflow
- name: Check Docker run: | docker info || echo "Docker not available" docker ps || echo "Cannot list containers"
-
Test with simpler Docker image
docker run hello-world docker run -i --rm alpine echo "test"
-
Verify environment variable
- name: Check GitHub token run: | echo "Token length: ${#GITHUB_PERSONAL_ACCESS_TOKEN}" echo "Token set: $([[ -n $GITHUB_PERSONAL_ACCESS_TOKEN ]] && echo yes || echo no)"
Alternative Approaches
-
Use HTTP/stdio MCP instead of Docker
- GitHub MCP server supports stdio mode
- Would avoid Docker dependency
-
Pre-pull Docker image
- name: Pre-pull GitHub MCP server run: docker pull ghcr.io/github/github-mcp-server:v0.19.1
-
Add Docker setup action
- name: Set up Docker uses: docker/setup-docker-action@v1
Long-term Improvements
- Add health checks for MCP servers before agent starts
- Provide better error messages when Docker unavailable
- Document Docker requirements for Copilot workflows
- Consider fallback to non-Docker GitHub MCP server
Summary
Previous Issue (#2357): ✅ RESOLVED
- Safe-outputs path mismatch is fixed
- Safe-outputs MCP server works perfectly
New Issue: ❌ GitHub MCP Docker Connection Failure
- Docker-based GitHub MCP server fails to start
- Likely infrastructure/Docker availability issue
- Requires separate investigation and fix
Pattern: COPILOT_GITHUB_MCP_DOCKER_CONNECTION_CLOSED
Investigation saved: /tmp/gh-aw/cache-memory/investigations/2025-10-25-18797919838.json
Related Issues
Closes #2357(safe-outputs path mismatch - now fixed)- Related to investigation runs that led to the fix
🤖 AI generated by Smoke Detector - Smoke Test Failure Investigator
AI generated by Smoke Detector - Smoke Test Failure Investigator