Skip to content

[plan] Review and decide on small helper files (map_helpers, git_helpers) #7144

@github-actions

Description

@github-actions

Objective

Review very small helper files and decide whether to keep them for future growth or merge them into related files.

Context

Two helper files contain minimal functions:

  • map_helpers.go (2 functions) - Map manipulation utilities
  • git_helpers.go (1 function) - Git utilities

These files may be:

  • Kept for future expansion as more helpers are added
  • Merged into more general utility files
  • Moved to appropriate packages (e.g., git_helpers.gopkg/gitutil)

Approach

  1. Analyze map_helpers.go:

    • Review the 2 functions and their usage across the codebase
    • Determine if more map helpers are likely to be added
    • Decision: Keep for growth OR merge into general utilities
  2. Analyze git_helpers.go:

    • Review the single function and its purpose
    • Check if it belongs in pkg/gitutil package
    • Check if more Git helpers are needed
    • Decision: Keep for growth OR move to pkg/gitutil OR merge elsewhere
  3. Document decision:

    • If keeping: Add file header explaining purpose and future use
    • If merging: Move functions and update imports
    • If moving to pkg/gitutil: Relocate and update imports
  4. Verify no breakage:

    • Run all tests after any changes
    • Ensure imports are correctly updated

Files to Review

  • pkg/workflow/map_helpers.go (2 functions)
  • pkg/workflow/git_helpers.go (1 function)
  • Potentially: pkg/gitutil/ (target for git_helpers)

Acceptance Criteria

AI generated by Plan Command for #7136

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions