-
Notifications
You must be signed in to change notification settings - Fork 109
Closed
Labels
ai-generatedcode-qualitydocumentationImprovements or additions to documentationImprovements or additions to documentationplan
Description
Objective
Establish monitoring for large files and document guidelines for when to consider splitting files.
Context
The analysis identified files approaching the "consider splitting" threshold:
js.go(41 functions) - JavaScript bundling/executionscripts.go(37 functions) - Script generationpermissions.go(37 functions) - Permission handlingcompiler_safe_outputs_consolidated.go(30 functions) - Already consolidated
Current guideline: Consider splitting when files exceed 50 functions.
Approach
-
Document file size guidelines in developer documentation:
- Add to
AGENTS.mdorDEVGUIDE.md - Specify: 50+ functions warrants consideration for splitting
- Clarify: Domain complexity may justify larger files
- Note: Current large files are appropriately sized for their domains
- Add to
-
Create monitoring mechanism:
- Add a simple script or test that warns when files exceed thresholds
- Could be integrated into CI or make targets
- Non-blocking - just informational
-
Document current large files:
- Note why each large file is justified (domain complexity)
- Set baseline for future comparison
Files to Create/Modify
AGENTS.mdorDEVGUIDE.md- Add file size guidelinesscripts/check-file-sizes.sh(optional) - Monitoring script.github/workflows/code-quality.yml(optional) - CI integration
Acceptance Criteria
- File size guidelines documented in developer docs
- Guidelines explain 50-function threshold
- Guidelines note that domain complexity can justify larger files
- Current large files documented with justification
- Optional: Simple monitoring script created
- Optional: CI integration for file size warnings (non-blocking)
Related to [refactor] Semantic Function Clustering Analysis - Code Organization Opportunities #7136
AI generated by Plan Command for #7136
Reactions are currently unavailable
Metadata
Metadata
Labels
ai-generatedcode-qualitydocumentationImprovements or additions to documentationImprovements or additions to documentationplan