-
Notifications
You must be signed in to change notification settings - Fork 181
Closed as not planned
Labels
Description
Objective
Resolve the critical type name collision where MCPGatewayConfig is defined with completely different structures in two locations.
Context
The same type name MCPGatewayConfig exists in:
pkg/cli/mcp_gateway_command.go:24- Container for multiple MCP serverspkg/workflow/tools_types.go:235- Configuration for gateway execution
These represent fundamentally different concepts and need distinct names.
Approach
- Rename
pkg/cli/mcp_gateway_command.go:24type toMCPGatewayServersConfig - Rename
pkg/workflow/tools_types.go:235type toMCPGatewayRuntimeConfig - Update all references throughout the codebase:
- Search for
MCPGatewayConfigusage - Update to use the appropriate renamed type based on context
- Update struct literal instantiations
- Search for
- Run
make testto verify no breakage
Files to Modify
pkg/cli/mcp_gateway_command.go- Rename type and update referencespkg/workflow/tools_types.go- Rename type and update references- Find and update all files referencing these types (use grep/ripgrep)
Acceptance Criteria
- No type name collisions exist
- Type names clearly indicate their purpose (servers vs runtime)
- All references updated correctly
- All tests pass (
make test) - Build succeeds (
make build)
Estimated Effort
2-3 hours
Related to #7369
AI generated by Plan Command for discussion #7368
Reactions are currently unavailable