Skip to content

Comments

Move reaction emoji to pre-activation job for immediate user feedback#10269

Merged
mnkiefer merged 4 commits intomainfrom
copilot/investigate-eye-reaction-timing
Jan 16, 2026
Merged

Move reaction emoji to pre-activation job for immediate user feedback#10269
mnkiefer merged 4 commits intomainfrom
copilot/investigate-eye-reaction-timing

Conversation

Copy link
Contributor

Copilot AI commented Jan 16, 2026

Reactions (👀 eyes, 🚀 rocket, etc.) were added in the activation job, which runs after all pre-activation checks (membership, stop-time, skip-if-match). Users saw no progress indicator during these checks, creating the impression that nothing was happening.

Changes

Architecture: Split reaction/comment logic into two phases

  • Pre-activation: Add reaction immediately after setup (instant feedback)
  • Activation: Add comment with workflow run URL (requires run context)

New scripts:

  • add_reaction.cjs - Adds reactions only (all event types: issues, PRs, discussions)
  • add_workflow_run_comment.cjs - Creates comment with workflow URL

Compiler modifications:

  • buildPreActivationJob(): Add reaction step after setup, grant write permissions (issues, pull-requests, discussions)
  • buildActivationJob(): Remove reaction step, keep comment creation only

Test updates: All reaction-related tests updated to expect reactions in pre-activation job

Example workflow behavior

pre_activation:
  steps:
    - name: Setup
    - name: Add eyes reaction for immediate feedback  # ← New: instant feedback
    - name: Check team membership
    - name: Check stop-time

activation:
  needs: [pre_activation]
  steps:
    - name: Add comment with workflow run link  # ← Modified: comment only

Users now see the reaction immediately when workflow triggers, before any validation checks run.

Original prompt

Why do on eyes reaction to triggering only happen in the activation and not in the pre-activation step or even immediately? This makes the user think that there is no progress/work being done.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 3 commits January 16, 2026 11:51
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copilot AI changed the title [WIP] Investigate timing of eye reaction during activation Move reaction emoji to pre-activation job for immediate user feedback Jan 16, 2026
Copilot AI requested a review from mnkiefer January 16, 2026 12:08
@mnkiefer mnkiefer marked this pull request as ready for review January 16, 2026 12:13
@mnkiefer mnkiefer merged commit c876f85 into main Jan 16, 2026
115 checks passed
@mnkiefer mnkiefer deleted the copilot/investigate-eye-reaction-timing branch January 16, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants