Fix assign_to_agent validation to support both issue_number and pull_number#10270
Merged
Fix assign_to_agent validation to support both issue_number and pull_number#10270
Conversation
…number Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
…umber Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix error in campaign generator run safe output
Fix assign_to_agent validation to support both issue_number and pull_number
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
assign_to_agentsafe output validation requiredissue_numberas mandatory, but the handler accepts eitherissue_numberORpull_numberfor assigning agents to issues or pull requests. This mismatch caused validation failures when attempting to assign agents to PRs.Changes
Validation config (
pkg/workflow/safe_output_validation_config.go):issue_numberfrom required to optional (OptionalPositiveInteger)pull_numberfield as optional (OptionalPositiveInteger)CustomValidation: "requiresOneOf:issue_number,pull_number"to enforce exactly-one semanticsTest config (
pkg/workflow/safe_output_validation_config_test.go):"requiresOneOf:issue_number,pull_number"to valid custom validation rulesJavaScript validator tests (
actions/setup/js/safe_output_type_validator.test.cjs):Example
The validation now matches the handler's actual behavior, preventing false negatives while maintaining safety guarantees.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.