Enforce minimum value validation for tools.timeout and tools.startup-timeout #11548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schema defines
minimum: 1for bothtools.timeoutandtools.startup-timeout, but runtime extraction infrontmatter_extraction_metadata.goaccepted any integer value, including zero and negatives.Changes
Modified extraction functions to validate minimum values and return errors for values < 1:
extractToolsTimeout(tools map[string]any) (int, error)extractToolsStartupTimeout(tools map[string]any) (int, error)Updated call sites in
compiler_orchestrator.goto handle validation errorsError messages follow existing patterns with actionable examples:
Rationale
Provides defense-in-depth alongside schema validation. Catches invalid values during tools config processing even when schema validation is bypassed (e.g., through imports or programmatic construction).
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.