Fix markdown code region balancer for mismatched fence lengths#11631
Merged
Fix markdown code region balancer for mismatched fence lengths#11631
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
The balancer was incorrectly rejecting valid fixes when a shorter fence cannot close a longer fence. For example, ``` (3 backticks) cannot close ```` (4 backticks), so the ``` should be treated as content inside the unclosed block, not as a separate unclosed fence. The bug was in the isInsideBlock helper function which only checked for paired blocks, not unclosed blocks. This caused the algorithm to add both fences to unclosedFences, which resulted in incorrect quality check rejection. Fix: Updated isInsideBlock to also check if a line is inside an unclosed block, preventing inner fences from being treated as separate openers. Added regression test for the bug found in workflow run #21314236532. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix markdown code region balancer issue
Fix markdown code region balancer for mismatched fence lengths
Jan 24, 2026
This was referenced Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The balancer was rejecting valid fixes when a shorter fence cannot close a longer fence (e.g., ``` cannot close ````), leaving markdown unbalanced.
Root cause:
isInsideBlock()only checkedpairedBlocks, notunclosedFences. This caused inner fences to be incorrectly treated as separate openers requiring their own closing fences.Changes:
isInsideBlock()to check if a line is inside an unclosed blockExample:
content
Previously: Left unbalanced (quality check rejected fix)
Now: Correctly closes with ```` at end
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.