Skip to content

Align MCP schema validation: remove "remote" from generic types, enforce strict properties #11725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Align MCP schema validation: remove "remote" from generic types, enforce strict properties #11725

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26d40e3
Initial plan
Copilot Jan 25, 2026
1641d9d
Align additionalProperties and enum values between schemas
Copilot Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions pkg/parser/schemas/main_workflow_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3427,12 +3427,14 @@
},
"mode": {
"type": "string",
"enum": ["stdio", "http", "remote", "local"],
"enum": ["stdio", "http", "local"],
"$comment": "Note: 'remote' is only valid for the GitHub tool's mode field, not for generic MCP server configurations. Valid types: stdio (command/container), http (URL-based), local (alias for stdio).",
"description": "MCP server mode"
},
"type": {
"type": "string",
"enum": ["stdio", "http", "remote", "local"],
"enum": ["stdio", "http", "local"],
"$comment": "Note: 'remote' is only valid for the GitHub tool's mode field, not for generic MCP server configurations. Valid types: stdio (command/container), http (URL-based), local (alias for stdio).",
"description": "MCP server type"
},
"version": {
Expand Down Expand Up @@ -3471,7 +3473,8 @@
"description": "Arguments passed to container entrypoint"
}
},
"additionalProperties": true
"$comment": "Strict validation: additionalProperties set to false to match mcp_config_schema.json and ensure consistent validation of custom MCP tools. Only explicitly defined properties are allowed.",
"additionalProperties": false
}
]
}
Expand Down