Skip to content

Add missing MCP properties to main workflow schema#11730

Merged
pelikhan merged 3 commits intomainfrom
copilot/add-missing-mcp-properties
Jan 25, 2026
Merged

Add missing MCP properties to main workflow schema#11730
pelikhan merged 3 commits intomainfrom
copilot/add-missing-mcp-properties

Conversation

Copy link
Contributor

Copilot AI commented Jan 25, 2026

Four MCP properties (registry, allowed, entrypoint, mounts) were implemented in pkg/parser/mcp.go and pkg/workflow/mcp-config-custom.go but missing from the JSON schema, preventing schema validation and IDE autocompletion.

Changes

Updated pkg/parser/schemas/main_workflow_schema.json:

  • Added to tools.additionalProperties (lines 3469-3510):

    • registry: string - MCP registry URI
    • allowed: array of strings - tool name allowlist
    • entrypoint: string - container entrypoint override
    • mounts: array with pattern ^[^:]+:[^:]+:(ro|rw)$ - volume mounts
  • Added to stdio_mcp_tool definition (lines 6376-6396):

    • entrypoint: string - container entrypoint override
    • mounts: array with pattern validation - volume mounts format enforcement

Example

mcp-servers:
  example:
    registry: https://api.mcp.github.com/v0/servers/microsoft/markitdown
    container: example/mcp:latest
    entrypoint: /bin/sh
    mounts:
      - "/workspace:/workspace:rw"
      - "/config:/config:ro"
    allowed: ["read-file", "write-file"]

All properties now validate against the schema with pattern enforcement for mount syntax.

Original prompt

This section details on the original issue you should resolve

<issue_title>[plan] Add missing MCP properties to main workflow schema</issue_title>
<issue_description>## Objective

Add 4 missing MCP properties to main_workflow_schema.json that are already implemented in the codebase but not validated by the schema.

Context

From discussion #11706: The main schema is missing registry, allowed, entrypoint, and mounts properties that are already implemented in pkg/parser/mcp.go, pkg/workflow/mcp-config-custom.go, and tested in mcp_config_compilation_test.go. This causes users to not discover these fields via schema validation.

Approach

Update pkg/parser/schemas/main_workflow_schema.json (lines 3398-3477) in the tools.additionalProperties section to include:

  1. registry (string) - URI to installation location from MCP registry
  2. allowed (array of strings) - List of allowed tool names
  3. entrypoint (string) - Container entrypoint override
  4. mounts (array) - Volume mounts with pattern ^[^:]+:[^:]+:(ro|rw)$

Files to Modify

  • pkg/parser/schemas/main_workflow_schema.json - Add 4 missing properties to tools.additionalProperties

Acceptance Criteria

  • registry property added with type string and description
  • allowed property added as array of strings
  • entrypoint property added with type string
  • mounts property added as array with pattern validation
  • All properties include examples matching existing documentation
  • Schema remains valid JSON
  • Run make build to embed updated schema

AI generated by Plan Command for discussion #11706

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits January 25, 2026 05:15
- Added registry, allowed, entrypoint, and mounts properties to stdio_mcp_tool definition
- Added registry and allowed properties to tools.additionalProperties section
- All properties include descriptions and examples
- Schema validation now accepts these properties in both mcp-servers and tools sections

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Tested registry, allowed, entrypoint, and mounts properties
- All properties compile correctly and appear in lock file
- Schema validation accepts all properties
- Existing test failures are unrelated to schema changes

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Add missing MCP properties to main workflow schema Add missing MCP properties to main workflow schema Jan 25, 2026
Copilot AI requested a review from pelikhan January 25, 2026 05:33
@pelikhan pelikhan marked this pull request as ready for review January 25, 2026 07:05
@pelikhan pelikhan merged commit 6ff866a into main Jan 25, 2026
@pelikhan pelikhan deleted the copilot/add-missing-mcp-properties branch January 25, 2026 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[plan] Add missing MCP properties to main workflow schema

2 participants