Skip to content

Conversation

@github-actions
Copy link
Contributor

Summary

CI cleaner workflow detected and fixed formatting issues on the main branch.

Changes Made

✅ Formatting Fixed

  • Reformatted: actions/setup/js/package-lock.json with prettier
    • Arrays condensed to single-line format for consistency
    • 98 insertions(+), 295 deletions(-)

✅ Linters Passed

  • Go formatting: ✓ All files properly formatted with go fmt
  • JavaScript formatting: ✓ All .cjs files formatted with prettier
  • JSON formatting: ✓ All JSON files formatted
  • golangci-lint: ✓ 0 issues found (v2.8.0)
  • Prettier check: ✓ All files use Prettier code style

Test Status

⚠️ Known Test Failures (Environment Issues)

JavaScript Tests (108 total failures):

  • collect_ndjson_output.test.cjs: 101 failures - Tests attempting to write to read-only /opt/gh-aw/safeoutputs/ directory
  • safe_outputs_mcp_server_defaults.test.cjs: 6 failures - Same read-only filesystem issue
  • safe_outputs_tools_loader.test.cjs: 1 failure - Attempting to delete file in read-only directory

Root Cause: Tests are running in GitHub Actions environment where /opt/gh-aw/safeoutputs/ is mounted as read-only, but tests expect to write validation files there.

Go Tests (2 packages with failures):

  • pkg/cli: Multiple test failures related to expected environment variables and configuration changes
  • pkg/workflow: Multiple test failures related to handler configuration expectations

Examples:

  • TestBuildHandlerManagerStep: Expects GH_AW_SAFE_OUTPUTS_HANDLER_CONFIG env var but it's not being set
  • TestCopilotEngineRenderGitHubMCPConfig: MCP configuration format expectations don't match current implementation
  • TestGenerateCopilotInstallerSteps: Version environment variable handling changed

Root Cause: Tests appear to be outdated relative to recent code changes in workflow compilation and handler configuration. Test expectations need to be updated to match current implementation.

Next Steps

  1. This PR can be merged as it only contains formatting fixes that passed all linters
  2. Test failures should be addressed separately in follow-up PRs:
    • Fix JavaScript test environment to use writable test directories
    • Update Go test expectations to match current handler/MCP configuration format
    • Update installer test expectations for version handling

CI Run

Verification Commands

All linting and formatting passed successfully:

# Go formatting (passed)
go fmt ./...

# JavaScript formatting (passed)
npx prettier --write '**/*.cjs' '**/*.json'

# Linting (passed)
golangci-lint run --timeout=5m  # v2.8.0 - 0 issues
npx prettier --check '**/*.cjs' '**/*.ts' '**/*.json'

Note: The title will be automatically prefixed with [ca] by the safe-outputs system.

AI generated by CI Cleaner

- Prettier reformatted actions/setup/js/package-lock.json
- Arrays condensed to single-line format for consistency
@pelikhan pelikhan marked this pull request as ready for review January 26, 2026 08:07
@pelikhan pelikhan merged commit f70235f into main Jan 26, 2026
@pelikhan pelikhan deleted the ci-cleaner-2026-01-26-92dab315cb275252 branch January 26, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants