Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/workflow/action_cache.go
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,8 @@ func (c *ActionCache) deduplicateEntries() {
}

// For each group with multiple entries, keep only the most precise one
toDelete := make([]string, 0)
deduplicationDetails := make([]string, 0) // Track details for user-friendly message
var toDelete []string
var deduplicationDetails []string // Track details for user-friendly message

for ek, keys := range groups {
if len(keys) <= 1 {
Expand Down Expand Up @@ -276,7 +276,7 @@ func (c *ActionCache) deduplicateEntries() {

// Keep the most precise version, mark others for deletion
keepVersion := keyInfos[0].versionRef
removedVersions := make([]string, 0)
var removedVersions []string
for i := 1; i < len(keyInfos); i++ {
toDelete = append(toDelete, keyInfos[i].key)
removedVersions = append(removedVersions, keyInfos[i].versionRef)
Expand Down
2 changes: 1 addition & 1 deletion pkg/workflow/compiler_safe_outputs_job.go
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ func (c *Compiler) buildConsolidatedSafeOutputsJob(data *WorkflowData, mainJobNa
}

// Insert app token steps
newSteps := make([]string, 0)
var newSteps []string
newSteps = append(newSteps, steps[:insertIndex]...)
newSteps = append(newSteps, appTokenSteps...)
newSteps = append(newSteps, steps[insertIndex:]...)
Expand Down
5 changes: 2 additions & 3 deletions pkg/workflow/jobs.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@ type JobManager struct {
// NewJobManager creates a new JobManager instance
func NewJobManager() *JobManager {
return &JobManager{
jobs: make(map[string]*Job),
jobOrder: make([]string, 0),
jobs: make(map[string]*Job),
}
}

Expand Down Expand Up @@ -429,7 +428,7 @@ func (jm *JobManager) GetTopologicalOrder() ([]string, error) {
}

// Start with jobs that have no dependencies (in-degree = 0)
queue := make([]string, 0)
var queue []string
for jobName, degree := range inDegree {
if degree == 0 {
queue = append(queue, jobName)
Expand Down
2 changes: 1 addition & 1 deletion pkg/workflow/mcp_setup_generator.go
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,7 @@ func (c *Compiler) generateMCPSetup(yaml *strings.Builder, tools map[string]any,
}

// Add remaining environment variables from mcpEnvVars
envVarNames := make([]string, 0)
var envVarNames []string
for envVarName := range mcpEnvVars {
if !addedEnvVars[envVarName] {
envVarNames = append(envVarNames, envVarName)
Expand Down
1 change: 0 additions & 1 deletion pkg/workflow/step_order_validation.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ type StepOrderTracker struct {
// NewStepOrderTracker creates a new step order tracker
func NewStepOrderTracker() *StepOrderTracker {
return &StepOrderTracker{
steps: make([]StepRecord, 0),
nextOrder: 0,
}
}
Expand Down
Loading