Skip to content

[WIP] Move app validation script to shell file in actions/setup/sh#12298

Merged
pelikhan merged 2 commits intocopilot/add-app-support-engine-fieldfrom
copilot/move-validation-script-to-shell
Jan 28, 2026
Merged

[WIP] Move app validation script to shell file in actions/setup/sh#12298
pelikhan merged 2 commits intocopilot/add-app-support-engine-fieldfrom
copilot/move-validation-script-to-shell

Conversation

Copy link
Contributor

Copilot AI commented Jan 28, 2026

  • Create validate_app_support_engine_field.sh script in actions/setup/sh/
  • Move validation logic from generateAppVariableValidationStep to the new shell script
  • Update generateAppVariableValidationStep to invoke the shell script instead
  • Fix any syntax errors in the shell script
  • Test the changes by compiling workflows
  • Run make agent-finish for full validation
Original prompt

Reference: https://github.com/githubnext/gh-aw/actions/runs/21444209269/job/61755334895#step:11:1

Move app validation script to shell file in actions/setup/sh

Invoke refactored script

Fix syntax (see error report)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

- Created validate_app_support_engine_field.sh in actions/setup/sh/
- Updated generateAppVariableValidationStep to invoke the shell script
- Refactored inline bash script logic into reusable shell script
- Recompiled all workflows with updated validation step

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan pelikhan marked this pull request as ready for review January 28, 2026 15:42
@pelikhan pelikhan merged commit 570a7c5 into copilot/add-app-support-engine-field Jan 28, 2026
@pelikhan pelikhan deleted the copilot/move-validation-script-to-shell branch January 28, 2026 15:42
Copilot AI requested a review from pelikhan January 28, 2026 15:43
Copilot stopped work on behalf of pelikhan due to an error January 28, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants