Skip to content

Fix order of processing project-related safe outputs#12485

Merged
mnkiefer merged 5 commits intomainfrom
copilot/fix-campaign-output-order
Jan 29, 2026
Merged

Fix order of processing project-related safe outputs#12485
mnkiefer merged 5 commits intomainfrom
copilot/fix-campaign-output-order

Conversation

Copy link
Contributor

Copilot AI commented Jan 29, 2026

Campaign Workflow Fixes ✅ COMPLETE

Issues Identified & Resolved

  • Analyze workflow run logs and identify root causes
  • Fix Step 1: Correct step ordering in safe_outputs job
  • Fix Step 2: Filter "copilot" from assignees in create_issue.cjs
  • Fix Step 3: Track issues needing copilot assignment
  • Fix Step 4: Test fixes locally
  • Fix Step 5: Recompile workflows
  • Fix Step 6: Validate changes
  • Address code review feedback

Final Implementation

Issue 1: Step Ordering ✅ FIXED

Root cause: Lock file in commit 6967905 had steps in wrong order
Fix: Recompilation applied correct order from compiler logic
Verification: Steps now execute: Project → Safe Outputs (with correct dependency)

Issue 2: Copilot Assignee Filtering ✅ FIXED

Root cause: JavaScript handler passed "copilot" to GitHub API (invalid user)
Implementation:

  1. Filter "copilot" before API call (create_issue.cjs)
  2. Track issues needing assignment in module-level variable
  3. Export list via getIssuesToAssignCopilot()
  4. Handler manager reads list and sets issues_to_assign_copilot output
  5. Reset state at handler manager start (prevents stale data)
  6. Existing assign_copilot_to_created_issues.cjs handles GraphQL assignment

Security Summary

No security vulnerabilities introduced or identified in the changes.

Validation Results ✅

  • ✅ All JavaScript tests pass (149 files, 3049 tests)
  • ✅ Go tests pass (TestCreateIssue*)
  • ✅ Build successful
  • ✅ Code formatting validated
  • ✅ Linting passes
  • ✅ Code review feedback addressed

Ready for Merge

All fixes complete and validated. The campaign workflow will now:

  1. Process project updates before other safe outputs
  2. Correctly filter and assign copilot to issues via GraphQL
  3. Maintain clean state across workflow runs
Original prompt

Fix campaign: https://github.com/githubnext/gh-aw/actions/runs/21470119549/job/61840772153

  • "Process Project-Related Safe outputs" must come before "Process safe outputs"
  • Fix: create_issue failed: Validation Failed: {"value":["copilot"],"resource":"Issue","field":"assignees","code":"invalid"}

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits January 29, 2026 08:10
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
- Recompiled workflow fixes step ordering (Project before Safe Outputs)
- Filter "copilot" from assignees before GitHub API call
- Track issues needing copilot assignment in global variable
- Export issues_to_assign_copilot output for separate assignment step

Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
@mnkiefer mnkiefer marked this pull request as ready for review January 29, 2026 08:17
@mnkiefer
Copy link
Contributor

@copilot fix lint errors

Copilot AI and others added 2 commits January 29, 2026 08:23
All tests pass - JavaScript (149 files) and Go tests
Build, format, and lint checks all pass
Ready for review

Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Address code review feedback: reset issuesToAssignCopilotGlobal at
start of handler manager to prevent stale data accumulation across
workflow runs

Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
@mnkiefer mnkiefer changed the title [WIP] Fix order of processing project-related safe outputs Fix order of processing project-related safe outputs Jan 29, 2026
@mnkiefer mnkiefer merged commit 9e8c015 into main Jan 29, 2026
118 checks passed
@mnkiefer mnkiefer deleted the copilot/fix-campaign-output-order branch January 29, 2026 08:31
Copilot AI requested a review from mnkiefer January 29, 2026 08:32
Copilot stopped work on behalf of mnkiefer due to an error January 29, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants