Remove hash-based compilation skip in run_push#12828
Merged
Conversation
This was referenced Jan 30, 2026
- Always recompile workflows regardless of frontmatter hash - Keep hash checking for observability/logging only - Log whether hash has changed for debugging purposes - Update function documentation to clarify purpose Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Test confirms workflows are recompiled even when hash matches - Verifies lock file modification time changes after collection - Documents the expected "always recompile" behavior Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Increase test sleep time to 100ms for reliable filesystem timestamps - Update collectWorkflowFiles documentation to clarify always-recompile behavior - Fix misleading comment about checking recompilation need Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Ensure compiler always recompiles workflows without hash optimization
Remove hash-based compilation skip in run_push
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
gh aw run --pushcommand was skipping workflow recompilation when the frontmatter hash matched between the markdown source and lock file. This optimization prevented workflows from being freshly compiled when triggered from the dashboard.Changes
pkg/cli/run_push.go: Remove conditional compilation logiccollectWorkflowFiles()pkg/cli/run_push_test.go: Add explicit test for always-recompile behaviorBehavior
Before: Skip compilation if
frontmatter-hashin lock file matches computed hashAfter: Always recompile, log hash match/mismatch status
Hash checking remains for warning users when running without
--pushand for debugging purposes.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.