Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 31, 2026

The noop safe output type was incorrectly included in the handler registry, causing it to appear in GH_AW_SAFE_OUTPUTS_HANDLER_CONFIG despite always being processed by a dedicated standalone step. Additionally, skip reason logging conflated project-related types with other standalone types.

Changes

Remove noop from handler registry

  • Deleted noop builder from handlerRegistry in pkg/workflow/compiler_safe_outputs_config.go
  • Noop is exclusively processed by standalone step (notify_comment.go), never by handler manager
  • Eliminates from GH_AW_SAFE_OUTPUTS_HANDLER_CONFIG:
- GH_AW_SAFE_OUTPUTS_HANDLER_CONFIG: '{"create_issue":{"max":5},"missing_data":{},"missing_tool":{},"noop":{"max":1}}'
+ GH_AW_SAFE_OUTPUTS_HANDLER_CONFIG: '{"create_issue":{"max":5},"missing_data":{},"missing_tool":{}}'

Distinguish skip reasons

  • Added PROJECT_RELATED_TYPES set in safe_output_handler_manager.cjs
  • Split skip logging into two categories:
    • "Handled by project handler step" for create_project, update_project, create_project_status_update, copy_project
    • "Handled by standalone step" for noop, assign_to_agent, create_agent_session, upload_asset
- Skipped (standalone step): 12
-   Types: update_project, create_project_status_update
+ Skipped (project handler step): 11
+   Types: update_project, create_project_status_update
+ Skipped (standalone step): 1
+   Types: noop

Updated tests

  • Removed noop cases from TestAutoEnabledHandlers (no longer auto-enabled in handler manager)
  • Updated skip reason expectations in safe_output_handler_manager.test.cjs
Original prompt

Analyze issue with "Process Project-related Safe Outputs". This is causing later Safe output project related calls in "Process Safe Outputs" steps to be skipped:
https://github.com/githubnext/gh-aw/actions/runs/21534552674/job/62057669718


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.


Changeset

  • Type: patch
  • Description: Document the two-file agentic workflow structure separating prompts (.github/agentics/) from frontmatter/locks and keep the noop safe output out of the handler manager config that workflow lock files ship.

Ahoy! This treasure was crafted by 🏴‍☠️ Changeset Generator

Copilot AI and others added 3 commits January 31, 2026 13:43
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issue with processing project-related Safe Outputs Remove noop from handler registry and clarify skip reason logging Jan 31, 2026
Copilot AI requested a review from mnkiefer January 31, 2026 13:59
@pelikhan pelikhan added the smoke label Jan 31, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2026

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2026

🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰

@github-actions
Copy link
Contributor

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2026

🎬 THE ENDSmoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

@github-actions
Copy link
Contributor

Agent Container Tool Check

Tool Status Version
bash 5.2.21
sh available
git 2.52.0
jq 1.7
yq 4.50.1
curl 8.5.0
gh 2.86.0
node 24.13.0
python3 3.13.11
go go1.24.12
java openjdk 21
dotnet not found

Result: 11/12 tools available ❌ FAIL

Note: .NET (dotnet) is not available in the agent container. All other essential development tools are present and functional.

AI generated by Agent Container Smoke Test

@github-actions
Copy link
Contributor

chore: refine default campaign orchestrator rules | Remove noop from handler registry and clarify skip reason logging
GitHub MCP (last 2 merged PRs) ✅ | safeinputs-gh PR list ✅
Serena activate ✅ | Playwright title ✅
Tavily search ✅ | File write ✅
Bash cat ✅ | Discussion comment ✅
Build gh-aw ✅
Overall: PASS

AI generated by Smoke Codex

@github-actions
Copy link
Contributor

Smoke Test Results

PRs: #12925 (chore: refine default campaign orchestrator rules), #12923 (Remove noop from handler registry)

✅ GitHub MCP
✅ Safe Inputs GH CLI
✅ Serena MCP
✅ Playwright
✅ File Writing
✅ Bash Tool
✅ Discussion Interaction
✅ Build gh-aw

Status: ✅ PASS

cc @mnkiefer @Copilot

AI generated by Smoke Copilot

@github-actions
Copy link
Contributor

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

@github-actions
Copy link
Contributor

Smoke Test Results:

Status: PASS ✅

AI generated by Smoke Claude

@pelikhan pelikhan marked this pull request as ready for review January 31, 2026 14:33
@pelikhan pelikhan merged commit 6558006 into main Jan 31, 2026
85 checks passed
@pelikhan pelikhan deleted the copilot/fix-project-related-safe-outputs branch January 31, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants