Add topological sort for safe output messages with temporary ID dependencies #13066

Copilot · 2026-02-01T10:21:07Z

Topological Sort for Safe Output Tool Calls ✅

Refactored per code review feedback

Recent Changes:

✅ Merged with origin/main branch
✅ Recompiled all 147 workflows
✅ Replaced recursive cycle detection with iterative mark-and-sweep algorithm
✅ Uses explicit stack with WHITE/GRAY/BLACK node coloring
✅ No recursion - iterative DFS with todo stack
✅ Added extensive testing (96 total tests across both modules)

Changes from previous feedback:

✅ Moved temporary ID helper functions to temporary_id.cjs
✅ Kept only graph/topological sort logic in new file

Implementation

Updated: temporary_id.cjs
- Added extractTemporaryIdReferences() - Finds all temp IDs referenced in a message
- Added getCreatedTemporaryId() - Gets the temp ID a message creates
- 62 tests in temporary_id.test.cjs (added 12 new tests)
File: safe_output_topological_sort.cjs
- buildDependencyGraph() - Builds a dependency graph from messages
- detectCycle() - Iterative cycle detection using mark-and-sweep with explicit stack
- topologicalSort() - Sorts using Kahn's algorithm
- sortSafeOutputMessages() - Main function to sort messages
- 34 tests in safe_output_topological_sort.test.cjs (added 11 extensive tests)
Updated: safe_output_unified_handler_manager.cjs
- Integrated topological sort before processing messages
- Messages now processed in dependency order
- Merged with main branch changes

How it works:

Analyzes messages to detect temporary ID dependencies
Messages creating entities are processed before messages referencing them
Uses Kahn's algorithm for topological sorting
Iterative cycle detection with WHITE/GRAY/BLACK coloring (no recursion)
Handles cycles gracefully by preserving original order
Enables single-pass resolution of temporary IDs in acyclic graphs

Test Coverage:

✅ 96 total tests (62 in temporary_id.test.cjs, 34 in safe_output_topological_sort.test.cjs)
✅ All 3,230 JavaScript tests passing
✅ Extensive test coverage including:

Large graphs with many dependencies (61 messages)
Deeply nested linear dependencies (6-level chains)
Multiple disconnected dependency chains
Diamond dependency patterns
Multiple temp ID references in single message
Empty/single message edge cases
Object reference preservation
Complex cycles (3+ nodes)
Mixed message types (issues, PRs, discussions, comments)
Dependency chains, duplicates, and real-world scenarios

Original prompt

The safe output unified handler receives a list of safe output types that may contains an arbitrary list of items (issues, PRs, discussions) that may be crossed linked through temporary ids.

Create a function that sorts on the safe output tool calls (separate file). Add extensive testing for that function. Use that function in unified handler.

Th function applies a topological sort of safe outputs to process items without temporary ids first. In graphs without loops, this should be enough to resolve all temporary ids in one pass.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Changeset

Type: patch
Description: Split temporary ID helpers into a dedicated temporary_id.cjs module and move the related tests.

Ahoy! This treasure was crafted by 🏴‍☠️ Changeset Generator

Changeset

Type: patch
Description: Sort safe output messages by temporary ID dependencies before dispatch so temporary IDs resolve in a single pass.

Ahoy! This treasure was crafted by 🏴‍☠️ Changeset Generator

- Create safe_output_topological_sort.cjs with sorting algorithm - Implement dependency graph analysis for temporary IDs - Add comprehensive test coverage (35 tests) - Integrate into unified handler manager - Enable single-pass resolution of temporary IDs Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

- All 35 topological sort tests passing - All unified handler tests passing - JavaScript formatting validated - TypeScript type checking passed - Build successful Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

- Define TEMPORARY_ID_PATTERN as module-level constant - Use constant instead of inline regex - Improves maintainability and consistency - All tests still passing Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-02-01T10:39:52Z

@copilot keep temporary id helper in temporary_id helpe file, and only keep graph /topological sort in new file

Add extensive testing.

- Simplify in-degree calculation using deps.size - Add assertions to verify only first occurrence is used for duplicates - All tests passing - Code more readable and maintainable Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

- Move extractTemporaryIdReferences to temporary_id.cjs - Move getCreatedTemporaryId to temporary_id.cjs - Keep only graph/topological sort logic in safe_output_topological_sort.cjs - Move tests to appropriate test files - temporary_id.test.cjs now has 62 tests (was 50) - safe_output_topological_sort.test.cjs now has 23 tests (was 35) - All 3215 JavaScript tests passing Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-02-01T10:49:52Z

@copilot keep temporary id helper in temporary_id helpe file, and only keep graph /topological sort in new file

Add extensive testing.

Done! Moved temporary ID helpers (extractTemporaryIdReferences and getCreatedTemporaryId) to temporary_id.cjs. The topological sort file now contains only graph/sorting logic. Added extensive testing - 62 tests in temporary_id.test.cjs (12 new) and 23 tests in safe_output_topological_sort.test.cjs. All 3215 JavaScript tests passing. (commit 4e1d101)

github-actions · 2026-02-01T10:55:53Z

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

github-actions · 2026-02-01T10:55:55Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

github-actions · 2026-02-01T10:55:56Z

🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

github-actions · 2026-02-01T10:55:57Z

💀 Blimey! Changeset Generator was cancelled and walked the plank! No treasure today, matey! ☠️

github-actions · 2026-02-01T10:58:11Z

Agent Container Tool Check

Tool	Status	Version
bash	✅	5.2.21
sh	✅	available
git	✅	2.52.0
jq	✅	1.7
yq	✅	4.50.1
curl	✅	8.5.0
gh	✅	2.86.0
node	✅	24.13.0
python3	✅	3.13.11
go	✅	1.24.12
java	❌	NOT FOUND
dotnet	❌	NOT FOUND

Result: 10/12 tools available ⚠️

Missing Tools:

java - command not found
dotnet - command not found

All core development tools (bash, git, jq, yq, curl, gh, node, python3, go) are available. Java and .NET runtimes are not installed in this container.

AI generated by Agent Container Smoke Test

github-actions · 2026-02-01T10:59:54Z

PR titles: Add Serena MCP tool usage statistical analysis with request/response size metrics | Merge main branch and recompile workflows
1 GitHub MCP ✅; 2 safeinputs-gh ✅; 3 Serena activate ✅
4 Playwright title ✅; 5 Tavily search ✅; 6 File write ✅
7 Bash cat ✅; 8 Discussion query+comment ✅; 9 Build ✅
Overall status: PASS

AI generated by Smoke Codex

github-actions · 2026-02-01T11:00:45Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

- Use iterative DFS with explicit stack instead of recursion - Implement mark-and-sweep with WHITE/GRAY/BLACK coloring - Track parent pointers to reconstruct cycle path - No recursion - uses todo stack for traversal - All 23 tests passing - All 3215 JavaScript tests passing Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-02-01T11:23:45Z

@copilot merge main and recompile
Add extensive testing for topological sort

…al-sort-function # Conflicts: # actions/setup/js/safe_output_unified_handler_manager.cjs

- Merged origin/main (resolved conflicts in safe_output_unified_handler_manager.cjs) - Recompiled all 147 workflows successfully - Added 11 extensive new tests for topological sort - Now 34 tests total (was 23) covering: - Large graphs with many dependencies (61 messages) - Deeply nested linear dependencies - Multiple disconnected chains - Diamond dependency patterns - Multiple temp ID references in single message - Empty/single message edge cases - Object reference preservation - 3-node cycles - Mixed message types (issues, PRs, discussions, comments) - All 3230 JavaScript tests passing Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-02-01T11:33:09Z

@copilot merge main and recompile
Add extensive testing for topological sort

Done! Merged origin/main (resolved conflicts in safe_output_unified_handler_manager.cjs) and recompiled all 147 workflows successfully. Added 11 extensive new tests - now 34 total (was 23) covering large graphs (61 messages), deeply nested chains, disconnected components, diamond patterns, multi-reference messages, edge cases, cycles, and mixed types. All 3,230 JavaScript tests passing. (commits 63d7184, fefb142)

github-actions · 2026-02-01T11:36:12Z

🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰

github-actions · 2026-02-01T11:36:12Z

🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

github-actions · 2026-02-01T11:36:15Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

github-actions · 2026-02-01T11:36:15Z

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

github-actions · 2026-02-01T11:38:33Z

Agent Container Tool Check ✅

Tool	Status	Version
bash	✅	5.2.21
sh	✅	available
git	✅	2.52.0
jq	✅	1.7
yq	✅	4.50.1
curl	✅	8.5.0
gh	✅	2.86.0
node	✅	24.13.0
python3	✅	3.13.11
go	✅	1.24.12
java	❌	not found
dotnet	❌	not found

Result: 10/12 tools available

Notes:

Java and .NET runtimes are not installed in the container
All core development tools (bash, git, jq, yq, curl, gh, node, python, go) are present and functional

AI generated by Agent Container Smoke Test

github-actions · 2026-02-01T11:40:12Z

Smoke Test Results

Recent PRs:

Remove legacy update-project job builder - now handled by unified handler #13074: [WIP] Update project to skip processing safe outputs
Add MCP tool usage statistics to logs command #13073: Add MCP tool usage statistics to logs command

Test Results:

GitHub MCP Testing: ✅
Safe Inputs GH CLI Testing: ✅
Serena MCP Testing: ✅
Make Build Testing: ✅
Playwright Testing: ✅
Tavily Web Search Testing: ✅
File Writing Testing: ✅
Bash Tool Testing: ✅
Discussion Interaction Testing: ✅

Overall Status: PASS

AI generated by Smoke Claude

github-actions · 2026-02-01T11:40:21Z

PRs: Fix: Use workflow ID instead of workflow name for comment search
PRs: Add MCP tool usage statistics to audit command
✅ GitHub MCP (last 2 merged PRs); ✅ Safeinputs gh pr list
✅ Serena activate; ✅ Playwright title; ✅ Tavily search
✅ File write; ✅ Bash cat; ✅ Discussion query+comment
✅ Build (make build)
Overall: PASS

AI generated by Smoke Codex

github-actions · 2026-02-01T11:40:59Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

Initial plan

749f167

Copilot AI assigned Copilot and pelikhan Feb 1, 2026

Copilot started work on behalf of pelikhan February 1, 2026 10:21 View session

Copilot AI and others added 3 commits February 1, 2026 10:30

Validate topological sort implementation

311715e

- All 35 topological sort tests passing - All unified handler tests passing - JavaScript formatting validated - TypeScript type checking passed - Build successful Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Address code review: Extract regex pattern as constant

767e23c

- Define TEMPORARY_ID_PATTERN as module-level constant - Use constant instead of inline regex - Improves maintainability and consistency - All tests still passing Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add function for topological sorting of safe outputs~~ Add topological sort for safe output messages with temporary ID dependencies Feb 1, 2026

Copilot AI requested a review from pelikhan February 1, 2026 10:41

Copilot finished work on behalf of pelikhan February 1, 2026 10:41

Copilot started work on behalf of pelikhan February 1, 2026 10:41 View session

Copilot finished work on behalf of pelikhan February 1, 2026 10:50

pelikhan marked this pull request as ready for review February 1, 2026 10:51

pelikhan added the smoke label Feb 1, 2026

github-actions bot added smoke-codex and removed smoke labels Feb 1, 2026

github-actions bot mentioned this pull request Feb 1, 2026

Smoke Test: Claude - 21561632887 #13068

Closed

pelikhan unassigned pelikhan and Copilot Feb 1, 2026

pelikhan assigned Copilot and pelikhan Feb 1, 2026

Copilot started work on behalf of pelikhan February 1, 2026 11:12 View session

Copilot AI requested a review from pelikhan February 1, 2026 11:18

Copilot finished work on behalf of pelikhan February 1, 2026 11:18

Copilot started work on behalf of pelikhan February 1, 2026 11:24 View session

Copilot AI and others added 2 commits February 1, 2026 11:29

Merge remote-tracking branch 'origin/main' into copilot/add-topologic…

63d7184

…al-sort-function # Conflicts: # actions/setup/js/safe_output_unified_handler_manager.cjs

Copilot finished work on behalf of pelikhan February 1, 2026 11:34

pelikhan added smoke and removed smoke-claude smoke-codex labels Feb 1, 2026

Add changeset [skip-ci]

58b808e

github-actions bot mentioned this pull request Feb 1, 2026

Smoke Test: Claude - 21562174281 #13076

Closed

github-actions bot added the smoke-claude label Feb 1, 2026

github-actions bot added smoke-codex and removed smoke labels Feb 1, 2026

pelikhan merged commit f5cd04d into main Feb 1, 2026
84 checks passed

pelikhan deleted the copilot/add-topological-sort-function branch February 1, 2026 11:42

Add topological sort for safe output messages with temporary ID dependencies #13066

Add topological sort for safe output messages with temporary ID dependencies #13066

Conversation

Copilot AI commented Feb 1, 2026 • edited by agentic-workflows-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Topological Sort for Safe Output Tool Calls ✅

Recent Changes:

Changes from previous feedback:

Implementation

How it works:

Test Coverage:

Changeset

Changeset

Uh oh!

pelikhan commented Feb 1, 2026

Uh oh!

Copilot AI commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 1, 2026 • edited by agentic-workflows-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 1, 2026

Agent Container Tool Check

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

pelikhan commented Feb 1, 2026

Uh oh!

Copilot AI commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026 • edited by agentic-workflows-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Agent Container Tool Check ✅

Uh oh!

github-actions bot commented Feb 1, 2026

Smoke Test Results

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Feb 1, 2026 •

edited by agentic-workflows-dev bot

Loading

github-actions bot commented Feb 1, 2026 •

edited

Loading

github-actions bot commented Feb 1, 2026 •

edited

Loading

github-actions bot commented Feb 1, 2026 •

edited by agentic-workflows-dev bot

Loading

github-actions bot commented Feb 1, 2026 •

edited by agentic-workflows-dev bot

Loading

github-actions bot commented Feb 1, 2026 •

edited

Loading

github-actions bot commented Feb 1, 2026 •

edited

Loading