Refactor compiler to use grouped shell redirects (fix SC2129)

[Copilot]

The workflow compiler generated multiple individual redirects to the same file, triggering 315 SC2129 shellcheck warnings across all 148 compiled workflows and causing unnecessary file operations.

Changes

Core refactoring (pkg/workflow/sh.go, pkg/workflow/unified_prompt_step.go):

• WritePromptTextToYAML() - Wrap heredocs in grouped redirect
• WritePromptTextToYAMLWithPlaceholders() - Same pattern for placeholder text
• generateUnifiedPromptCreationStep() - Use single redirect for initial file write
• generateUnifiedPromptStep() - Use single redirect for append operations

Pattern change:

# Before (315 SC2129 warnings)
cat << 'EOF' >> "$GH_AW_PROMPT"
content
EOF
cat file1 >> "$GH_AW_PROMPT"
cat file2 >> "$GH_AW_PROMPT"

# After (0 warnings, single file operation)
{
  cat << 'EOF'
  content
  EOF
  cat file1
  cat file2
} >> "$GH_AW_PROMPT"

Test updates:

• Updated unit and integration tests to validate grouped redirect pattern
• Fixed pattern matching for new shell command structure

Workflow recompilation:

• Recompiled all 148 workflows with new pattern
• Verified SC2129 warnings eliminated in generated .lock.yml files

Impact

• Eliminates all 315 shellcheck style warnings
• Reduces file operations (better performance)
• Cleaner generated shell scripts
• No functional changes to workflow behavior

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[Code Quality] Refactor compiler to use grouped shell redirects (fix SC2129)</issue_title>
<issue_description>### Description

The workflow compiler generates shell scripts that use multiple individual redirects instead of grouped redirects, triggering 315 shellcheck SC2129 style warnings across all 148 compiled workflows.

Current Pattern (Problematic)

cat << 'EOF' > "$FILE"
content
EOF
cat file1 >> "$FILE"
cat file2 >> "$FILE"

Issue: Each redirect opens the file separately, reducing performance and readability.

Recommended Pattern

{
  cat << 'EOF'
  content
  EOF
  cat file1
  cat file2
} > "$FILE"

Benefits: Single file operation, better performance, cleaner code.

Files Affected

• pkg/workflow/compiler*.go - Template generation code
• All 148 .lock.yml files (will be auto-regenerated after compiler fix)

Success Criteria

• Compiler generates grouped redirects for multi-line file writes
• All shellcheck SC2129 warnings eliminated (315 → 0)
• Existing workflows recompiled with new pattern
• No regression in workflow functionality
• Unit tests verify new code generation pattern

Impact

• Severity: Low (style issue, not functional bug)
• Scope: 315 instances across 148 workflows (100% affected)
• Benefit: Improved code quality, better performance, cleaner audits

Source

Extracted from:

• Discussion githubnext/gh-aw#13119 - Static Analysis Report (Feb 1)
• Discussion githubnext/gh-aw#11769 - Static Analysis Report (Jan 25)

Implementation Hints

Look for code that generates shell script output in the compiler. Search for patterns like:

// Find code that writes multiple cat/echo commands with >> redirects
// Replace with grouped command pattern

Priority: Medium - Systematic issue affecting all workflows, but low severity

AI generated by Discussion Task Miner - Code Quality Improvement Agent

• expires on Feb 15, 2026, 5:09 PM UTC

Comments on the Issue (you are @copilot in this section)

• Fixes [Code Quality] Refactor compiler to use grouped shell redirects (fix SC2129) #13142

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[github-actions]

🔍 PR Triage Results

Category: refactor | Risk: medium | Priority: 58/100

Scores Breakdown

• Impact: 25/50 - Code quality improvement that eliminates 315 shellcheck SC2129 warnings across all 148 workflows
• Urgency: 18/30 - Systematic issue affecting maintainability and code quality audits
• Quality: 15/20 - Good - detailed description with before/after examples, comprehensive test updates

📋 Recommended Action: fast-track

Excellent code quality improvement. The refactoring uses grouped shell redirects instead of multiple individual redirects, reducing file operations and improving readability. All workflow lock files recompiled with the new pattern.

Ready for review once CI passes.

---

Triaged by PR Triage Agent on 2026-02-02

AI generated by PR Triage Agent