-
Notifications
You must be signed in to change notification settings - Fork 46
Add Missing Tools column to logs overview table with verbose mode support #1319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add MissingToolCount field to WorkflowRun struct - Populate count from MissingTools array in ProcessedRun - Display "Missing" column in overview table alongside Errors/Warnings - Include total missing tools count in summary row - Add comprehensive test coverage for missing tools display Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot in verbose mode, show full list of missing tools |
- Pass verbose parameter to displayLogsOverview - In verbose mode, display actual tool names instead of count - Update function signature to accept ProcessedRun for access to tool details - Truncate long tool lists to fit table (max 30 chars) - Update all tests to use new signature with ProcessedRun - Test both verbose and non-verbose modes Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done! The overview table now shows full tool names in verbose mode. Normal mode:
Verbose mode (
Commit: Added in commit that enhances the overview table to display actual tool names when |
|
@copilot format, lint, fix tests |
- Remove unused containsString helper function - Remove unused strings import - All linter checks now pass Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done! Fixed all linting issues. Changes:
Validation:
Commit: Fixed in latest commit. |
Add Missing Tools Column to Logs Overview Table ✅
Problem Solved
The
logscommand now prominently displays missing tools in the main overview table. Previously, missing tools were parsed correctly but only shown in a separate detailed summary section, making them easy to overlook.Solution
Added a "Missing" column to the logs overview table showing the count of missing tools for each workflow run, positioned alongside the existing Errors and Warnings columns for immediate visibility.
Enhanced with verbose mode support: When running with the
--verboseflag, the Missing column displays the actual tool names instead of just the count.Changes Made
MissingToolCountfield toWorkflowRunstructMissingToolsarray when preparing overview displaydisplayLogsOverviewto acceptProcessedRunandverboseparametersmake fmtVisual Example
Normal Mode (
gh aw logs):Verbose Mode (
gh aw logs --verbose):Note: In verbose mode, the "Missing" column shows actual tool names (truncated to 30 chars if needed).
Test Coverage
Created
pkg/cli/logs_overview_test.gowith 10 comprehensive tests:Implementation Details
Modified Files:
pkg/cli/logs.go- Enhanced to support verbose modeMissingToolCount intfield to WorkflowRun structdisplayLogsOverviewsignature to acceptProcessedRunandverboseboolpkg/cli/logs_overview_test.go- Updated tests to use new signatureKey Benefits
--verboseBackward Compatibility
✅ No breaking changes - all existing functionality preserved
✅ Additional column enhances existing display
✅ Detailed missing tools summary section still displays below the overview
Testing Results
How It Works
extractMissingToolsFromRun()parsesagent_output.jsonartifactsProcessedRun.MissingToolsarraylen(pr.MissingTools)WorkflowRun.MissingToolCountfielddisplayLogsOverview()receivesverboseparameterdisplayMissingToolsAnalysis()still shows detailed breakdown separatelyThis implementation ensures that missing tools are now prominently visible in the main logs overview, with optional verbose mode to see the actual tool names.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.