-
Notifications
You must be signed in to change notification settings - Fork 122
Remove support for top-level sandbox: false and sandbox.gateway/mcp: false #13370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot must be able to disable agent firewall: sandbox: |
- Restored Disabled field in AgentSandboxConfig struct - Restored all code that checks Disabled field (150+ lines) - Restored sandbox_disabled_test.go and other test files - Updated JSON schema to allow boolean false for sandbox.agent - Added validation that ONLY rejects: * sandbox: false (top-level) * sandbox.gateway: false * sandbox.mcp: false - sandbox.agent: false IS NOW SUPPORTED to disable AWF firewall - Updated documentation to clarify supported syntax Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Fixed in commit 3817aca. The What was changed:
The PR now correctly implements the original requirements: remove top-level |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot remove this entry, sandbox: boolean is not supported anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in commit d0c363f. Removed the boolean type from the top-level sandbox field's oneOf array in the JSON schema. Top-level sandbox: false is now rejected by schema validation, while sandbox.agent: false remains supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in commit d0c363f. Removed the boolean type entry from the top-level sandbox field in the JSON schema. The schema now only accepts string or object types for the top-level sandbox field, rejecting sandbox: false at schema validation time.
- Removed boolean option from sandbox field's oneOf array - Top-level sandbox: false now rejected by schema validation - sandbox.agent: false still supported (has its own boolean option) - Schema validation will catch sandbox: false early with clear error Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Summary: Remove sandbox: false (top-level) and sandbox.gateway/mcp: false
Per the original requirements, this PR removes support for:
sandbox: false(top-level boolean - NOT supported, rejected by schema)sandbox.gateway: false(NOT supported, rejected by custom validation)sandbox.mcp: false(NOT supported, rejected by schema)But KEEPS support for:
sandbox.agent: false(SUPPORTED - disables AWF firewall)Changes Made
JSON Schema Updates
sandboxfield (only string/object allowed)sandbox.agentfield (allows disabling AWF)sandbox: falseearly before custom validationValidation
validateUnsupportedSandboxSyntax()for additional checks onsandbox.gateway: falsesandbox.agent: falseinstead ofsandbox: falseCode
Disabledfield inAgentSandboxConfigstruct (needed forsandbox.agent: false)Disabledfield throughout codebase (~150 lines)isSandboxDisabled()checks forsandbox.agent: falseTests
sandbox_disabled_test.go(testssandbox.agent: falsefunctionality)Disabledfield referencesDocumentation
sandbox.agent: falseas supported optionsandbox: falseis not supportedExamples
❌ Not Supported:
✅ Supported:
Build & Test Status
✅ Build successful
✅ Code formatted
✅ Validation tests pass
✅ Schema correctly rejects unsupported syntaxes
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.