-
Notifications
You must be signed in to change notification settings - Fork 235
Fix smoke-claude: clarify safe-outputs auto-targeting for PR comments #13507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -104,11 +104,11 @@ timeout-minutes: 15 | |
| - Run URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }} | ||
| - Timestamp | ||
|
|
||
| 2. Add a **very brief** comment (max 5-10 lines) to the current pull request with: | ||
| 2. **Only if this workflow was triggered by a pull_request event**: Use the `add_comment` tool to add a **very brief** comment (max 5-10 lines) to the triggering pull request (omit the `item_number` parameter to auto-target the triggering PR) with: | ||
| - PR titles only (no descriptions) | ||
| - ✅ or ❌ for each test result | ||
| - Overall status: PASS or FAIL | ||
|
|
||
| 3. Use the `add_comment` tool to add a **fun comic-book style comment** to the latest discussion (using the `discussion_number` you extracted in step 9) - be playful and use comic-book language like "💥 WHOOSH!" | ||
| 3. Use the `add_comment` tool with `item_number` set to the discussion number you extracted in step 9 to add a **fun comic-book style comment** to that discussion - be playful and use comic-book language like "💥 WHOOSH!" | ||
|
|
||
| If all tests pass, add the label `smoke-claude` to the pull request. | ||
| If all tests pass, use the `add_labels` tool to add the label `smoke-claude` to the pull request (omit the `item_number` parameter to auto-target the triggering PR if this workflow was triggered by a pull_request event). | ||
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow still has conflicting guidance for discussion comments: step 9 (Test Requirements) instructs using
add_commentwith adiscussion_numberparameter, but the safe-outputsadd_commenttool schema only supportsitem_number(and rejects additional properties). This inconsistency can cause the agent to emit invalid tool calls or follow the wrong parameter name—please update the step 9 instruction to match theitem_numberparameter used here (or otherwise align both sections).