Skip to content

Comments

Fix TestUpgradeCommand_UpdatesAgentFiles after agent template removal#13652

Merged
pelikhan merged 2 commits intomainfrom
copilot/review-action-job-62437868339
Feb 4, 2026
Merged

Fix TestUpgradeCommand_UpdatesAgentFiles after agent template removal#13652
pelikhan merged 2 commits intomainfrom
copilot/review-action-job-62437868339

Conversation

Copy link
Contributor

Copilot AI commented Feb 4, 2026

PR #13612 removed embedded template files and switched to downloading agentic-workflows.agent.md from GitHub on demand. The upgrade command no longer creates github-agentic-workflows.md or upgrade-agentic-workflows.md - these files are expected only in the gh-aw repository itself.

Changes

  • Removed assertions for files no longer created by upgrade command
  • Updated test to verify only dispatcher agent file creation
  • Added comment documenting behavior change
// Before: Expected 3 files to be created
assert.FileExists(t, instructionsFile, "Copilot instructions file should be created")
assert.FileExists(t, dispatcherFile, "Dispatcher agent file should be created")
assert.FileExists(t, upgradePromptFile, "Upgrade prompt file should be created")

// After: Only dispatcher agent is downloaded/created
dispatcherFile := filepath.Join(tmpDir, ".github", "agents", "agentic-workflows.agent.md")
assert.FileExists(t, dispatcherFile, "Dispatcher agent file should be created")
Original prompt

Reference: https://github.com/github/gh-aw/actions/runs/21658317320/job/62437868339#step:8:1


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Review action job results for run 21658317320 Fix TestUpgradeCommand_UpdatesAgentFiles after agent template removal Feb 4, 2026
Copilot AI requested a review from pelikhan February 4, 2026 04:40
@pelikhan pelikhan marked this pull request as ready for review February 4, 2026 04:41
Copilot AI review requested due to automatic review settings February 4, 2026 04:41
@pelikhan pelikhan merged commit af9e7b8 into main Feb 4, 2026
152 checks passed
@pelikhan pelikhan deleted the copilot/review-action-job-62437868339 branch February 4, 2026 04:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the TestUpgradeCommand_UpdatesAgentFiles test to align with behavior changes introduced in PR #13612, which removed embedded template files and switched to downloading the dispatcher agent file from GitHub on demand.

Changes:

  • Removed test assertions for github-agentic-workflows.md and upgrade-agentic-workflows.md files that are no longer created
  • Updated test to verify only the dispatcher agent file (.github/agents/agentic-workflows.agent.md) is downloaded/created
  • Added explanatory comment documenting the behavior change from PR #13612

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants