Remove inline safe-inputs shadowing imports in daily-performance-summary#13711
Merged
Remove inline safe-inputs shadowing imports in daily-performance-summary#13711
Conversation
The workflow was defining github-issue-query, github-pr-query, and github-discussion-query inline (338 lines) instead of using the imported version from shared/github-queries-safe-input.md. This prevented the "precomputed" (imported) tools from being used due to precedence rules. Fixed by removing the inline definitions and relying on the import. Refs: https://github.com/github/gh-aw/actions/runs/21670892296 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Investigate why the issue query is not precomputed
Remove inline safe-inputs shadowing imports in daily-performance-summary
Feb 4, 2026
pelikhan
approved these changes
Feb 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes duplicated safe-input tool definitions from the daily-performance-summary.md workflow file. The workflow was defining three GitHub query tools (github-issue-query, github-pr-query, and github-discussion-query) inline while also importing them from shared/github-queries-safe-input.md. Due to the merge precedence logic in the codebase, inline definitions take priority over imports, causing the imported tools to be ignored.
Changes:
- Removed 338 lines of inline safe-input tool definitions from the workflow file
- Workflow now properly uses the imported tools from the shared configuration
- Updated the compiled lock file to reflect the removal (hash updated, extra blank line removed)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/daily-performance-summary.md |
Removed duplicate inline definitions of three GitHub query tools (lines 20-357), allowing imported versions from shared file to be used |
.github/workflows/daily-performance-summary.lock.yml |
Updated frontmatter hash and removed extra blank line in compiled output |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
daily-performance-summary.mdworkflow definedgithub-issue-query,github-pr-query, andgithub-discussion-queryinline (338 lines) while also importingshared/github-queries-safe-input.md. The merge logic insafe_inputs_parser.goskips imported tools when they exist in main config, causing the import to be ignored.Changes
daily-performance-summary.mdshared/github-queries-safe-input.mdThe precedence logic is by design:
No other workflows have this duplication pattern.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/github/gh-aw/actions/runs/21670892296/usr/bin/curl curl -s -H Authorization: token REDACTED(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.