Skip to content

Remove inline safe-inputs shadowing imports in daily-performance-summary#13711

Merged
pelikhan merged 2 commits intomainfrom
copilot/investigate-precompute-issue-query
Feb 4, 2026
Merged

Remove inline safe-inputs shadowing imports in daily-performance-summary#13711
pelikhan merged 2 commits intomainfrom
copilot/investigate-precompute-issue-query

Conversation

Copy link
Contributor

Copilot AI commented Feb 4, 2026

The daily-performance-summary.md workflow defined github-issue-query, github-pr-query, and github-discussion-query inline (338 lines) while also importing shared/github-queries-safe-input.md. The merge logic in safe_inputs_parser.go skips imported tools when they exist in main config, causing the import to be ignored.

Changes

  • Removed inline safe-inputs block (lines 20-357) from daily-performance-summary.md
  • Workflow now uses imported tools from shared/github-queries-safe-input.md
  • Updated compiled lock file reflects the change

The precedence logic is by design:

// pkg/workflow/safe_inputs_parser.go:284-287
if _, exists := main.Tools[toolName]; exists {
    safeInputsLog.Printf("Skipping imported tool '%s' - already defined in main config", toolName)
    continue
}

No other workflows have this duplication pattern.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/github/gh-aw/actions/runs/21670892296
    • Triggering command: /usr/bin/curl curl -s -H Authorization: token REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Reference: https://github.com/github/gh-aw/actions/runs/21670892296/job/62478236480#step:24:1

Investigate why the issue query is not precomputed


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

The workflow was defining github-issue-query, github-pr-query, and
github-discussion-query inline (338 lines) instead of using the imported
version from shared/github-queries-safe-input.md. This prevented the
"precomputed" (imported) tools from being used due to precedence rules.

Fixed by removing the inline definitions and relying on the import.

Refs: https://github.com/github/gh-aw/actions/runs/21670892296

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Investigate why the issue query is not precomputed Remove inline safe-inputs shadowing imports in daily-performance-summary Feb 4, 2026
Copilot AI requested a review from pelikhan February 4, 2026 12:42
@pelikhan pelikhan marked this pull request as ready for review February 4, 2026 12:48
Copilot AI review requested due to automatic review settings February 4, 2026 12:48
@pelikhan pelikhan merged commit fb43081 into main Feb 4, 2026
4 checks passed
@pelikhan pelikhan deleted the copilot/investigate-precompute-issue-query branch February 4, 2026 12:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes duplicated safe-input tool definitions from the daily-performance-summary.md workflow file. The workflow was defining three GitHub query tools (github-issue-query, github-pr-query, and github-discussion-query) inline while also importing them from shared/github-queries-safe-input.md. Due to the merge precedence logic in the codebase, inline definitions take priority over imports, causing the imported tools to be ignored.

Changes:

  • Removed 338 lines of inline safe-input tool definitions from the workflow file
  • Workflow now properly uses the imported tools from the shared configuration
  • Updated the compiled lock file to reflect the removal (hash updated, extra blank line removed)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/daily-performance-summary.md Removed duplicate inline definitions of three GitHub query tools (lines 20-357), allowing imported versions from shared file to be used
.github/workflows/daily-performance-summary.lock.yml Updated frontmatter hash and removed extra blank line in compiled output

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments