Enable concurrency by propagating context from command level

[Copilot]

Local context.Background() calls in CLI functions prevented proper cancellation propagation and blocked concurrent execution.

Changes

Function signatures updated to accept context:

• CreateWorkflowInteractively
• compileWorkflow (method)
• recompileWorkflow
• collectWorkflowFiles
• installWorkflowInTrialMode
• RunWorkflowTrials

Command handlers now pass cmd.Context():

• add command → RunAddInteractive
• new command → CreateWorkflowInteractively
• trial command → RunWorkflowTrials
• run --push → collectWorkflowFiles → recompileWorkflow

Removed local context creation in:

• pkg/cli/add_command.go:116
• pkg/cli/interactive.go:497
• pkg/cli/run_push.go:143
• pkg/cli/trial_repository.go:229

Example

Before:

func collectWorkflowFiles(workflowPath string, verbose bool) ([]string, error) {
    ctx := context.Background()  // Local context breaks cancellation chain
    if err := recompileWorkflow(ctx, workflowPath, verbose); err != nil {
        return nil, err
    }
    // ...
}

After:

func collectWorkflowFiles(ctx context.Context, workflowPath string, verbose bool) ([]string, error) {
    if err := recompileWorkflow(ctx, workflowPath, verbose); err != nil {
        return nil, err
    }
    // ...
}

Context now flows: cmd.Context() → service functions → CompileWorkflows, enabling proper cancellation and concurrent operations.

Original prompt

Remove the global context object created in the cli in favor of a local variable context that gets passed around. This will allow concurrency.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[pelikhan]

@copilot the command should still be cancellable but context.Background should only be used in top level function

[Copilot]

@copilot the command should still be cancellable but context.Background should only be used in top level function

The changes already follow this pattern:

Commands are cancellable: Using cmd.Context() in command handlers (e.g., add_command.go:115, main.go:100, trial_command.go:159) which properly handles SIGINT and cancellation signals from Cobra.

context.Background() only in top-level: Removed from nested functions (was in add_command.go:116, interactive.go:497, run_push.go:143, trial_repository.go:229). Now only used in test files where it's appropriate.

The context flow is: cmd.Context() → RunAddInteractive/CreateWorkflowInteractively/etc → CompileWorkflows, enabling proper cancellation propagation throughout the call chain.

Is there a specific location where you'd like me to use context.Background() instead of cmd.Context()?

[Copilot]

Pull request overview

This PR enables proper cancellation and concurrency support by propagating context from the command level down through the CLI functions to the compilation layer. Previously, local context.Background() calls were created at intermediate layers, breaking the cancellation chain.

Changes:

• Updated function signatures to accept context.Context as first parameter: CreateWorkflowInteractively, compileWorkflow, recompileWorkflow, collectWorkflowFiles, installWorkflowInTrialMode, and RunWorkflowTrials
• Modified command handlers to pass cmd.Context() instead of creating local contexts
• Updated test files to use context.Background() appropriately

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
pkg/cli/trial_repository.go	Updated installWorkflowInTrialMode to accept context parameter and pass it to CompileWorkflows
pkg/cli/trial_command.go	Updated RunWorkflowTrials signature and command handler to pass context from cmd.Context()
pkg/cli/run_workflow_execution.go	Updated call to collectWorkflowFiles to pass context
pkg/cli/run_push_test.go	Updated test calls to use context.Background()
pkg/cli/run_push.go	Updated collectWorkflowFiles and recompileWorkflow signatures; removed local context.Background() creation
pkg/cli/interactive_test.go	Updated test calls to use context.Background()
pkg/cli/interactive.go	Updated CreateWorkflowInteractively and compileWorkflow signatures to accept context
pkg/cli/add_command.go	Removed local context creation and unused import; passes cmd.Context() to RunAddInteractive
cmd/gh-aw/main.go	Updated to pass cmd.Context() to CreateWorkflowInteractively

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.