-
Notifications
You must be signed in to change notification settings - Fork 51
Add symbol search verification to smoke workflow Serena MCP tests #13955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -71,7 +71,9 @@ timeout-minutes: 15 | |||||
|
|
||||||
| 1. **GitHub MCP Testing**: Review the last 2 merged pull requests in ${{ github.repository }} | ||||||
| 2. **Safe Inputs GH CLI Testing**: Use the `safeinputs-gh` tool to query 2 pull requests from ${{ github.repository }} (use args: "pr list --repo ${{ github.repository }} --limit 2 --json number,title,author") | ||||||
| 3. **Serena MCP Testing**: Use the Serena MCP server tool `activate_project` to initialize the workspace at `${{ github.workspace }}` and verify it succeeds (do NOT use bash to run go commands - use Serena's MCP tools) | ||||||
| 3. **Serena MCP Testing**: | ||||||
| - Use the Serena MCP server tool `activate_project` to initialize the workspace at `${{ github.workspace }}` and verify it succeeds (do NOT use bash to run go commands - use Serena's MCP tools) | ||||||
| - After initialization, use the `find_symbol` tool to search for symbols (find which tool to call) and verify that at least 3 symbols are found in the results | ||||||
|
||||||
| - After initialization, use the `find_symbol` tool to search for symbols (find which tool to call) and verify that at least 3 symbols are found in the results | |
| - After initialization, use the `find_symbol` tool to search for function or method symbols and verify that at least 3 symbols are found in the results |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -105,7 +105,9 @@ strict: true | |||||
|
|
||||||
| 1. **GitHub MCP Testing**: Review the last 2 merged pull requests in ${{ github.repository }} | ||||||
| 2. **Safe Inputs GH CLI Testing**: Use the `safeinputs-gh` tool to query 2 pull requests from ${{ github.repository }} (use args: "pr list --repo ${{ github.repository }} --limit 2 --json number,title,author") | ||||||
| 3. **Serena MCP Testing**: Use the Serena MCP server tool `activate_project` to initialize the workspace at `${{ github.workspace }}` and verify it succeeds (do NOT use bash to run go commands - use Serena's MCP tools) | ||||||
| 3. **Serena MCP Testing**: | ||||||
| - Use the Serena MCP server tool `activate_project` to initialize the workspace at `${{ github.workspace }}` and verify it succeeds (do NOT use bash to run go commands - use Serena's MCP tools) | ||||||
| - After initialization, use the `find_symbol` tool to search for symbols (find which tool to call) and verify that at least 3 symbols are found in the results | ||||||
|
||||||
| - After initialization, use the `find_symbol` tool to search for symbols (find which tool to call) and verify that at least 3 symbols are found in the results | |
| - After initialization, use the `find_symbol` tool to search for function or method symbols and verify that at least 3 symbols are found in the results |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -64,7 +64,9 @@ timeout-minutes: 15 | |||||
|
|
||||||
| 1. **GitHub MCP Testing**: Review the last 2 merged pull requests in ${{ github.repository }} | ||||||
| 2. **Safe Inputs GH CLI Testing**: Use the `safeinputs-gh` tool to query 2 pull requests from ${{ github.repository }} (use args: "pr list --repo ${{ github.repository }} --limit 2 --json number,title,author") | ||||||
| 3. **Serena MCP Testing**: Use the Serena MCP server tool `activate_project` to initialize the workspace at `${{ github.workspace }}` and verify it succeeds (do NOT use bash to run go commands - use Serena's MCP tools) | ||||||
| 3. **Serena MCP Testing**: | ||||||
| - Use the Serena MCP server tool `activate_project` to initialize the workspace at `${{ github.workspace }}` and verify it succeeds (do NOT use bash to run go commands - use Serena's MCP tools) | ||||||
| - After initialization, use the `find_symbol` tool to search for symbols (find which tool to call) and verify that at least 3 symbols are found in the results | ||||||
|
||||||
| - After initialization, use the `find_symbol` tool to search for symbols (find which tool to call) and verify that at least 3 symbols are found in the results | |
| - After initialization, use the `find_symbol` tool to search for function or method symbols (i.e., discover callable Serena tools) and verify that at least 3 symbols are found in the results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phrase "(find which tool to call)" is somewhat ambiguous. It's unclear whether this means:
find_symbol)Consider clarifying this instruction. For example: "use the
find_symboltool to search for function or method symbols" or "use thefind_symboltool without any specific query to discover available symbols".