Skip to content

Add serena container to predownload list when enabled#13956

Merged
pelikhan merged 5 commits intomainfrom
copilot/add-serena-container-imag
Feb 5, 2026
Merged

Add serena container to predownload list when enabled#13956
pelikhan merged 5 commits intomainfrom
copilot/add-serena-container-imag

Conversation

Copy link
Contributor

Copilot AI commented Feb 5, 2026

The serena tool's container image was not being predownloaded, causing workflow startup delays.

Changes

  • Modified pkg/workflow/docker.go: Extended collectDockerImages() to detect serena tool configuration

    • Only includes container when serena is in docker mode (default)
    • Skips when mode: local is set (uses uvx instead of container)
    • Leverages selectSerenaContainer() for language-specific container selection
    • Appends :latest tag consistent with MCP config renderer
  • Added test coverage: Three scenarios in docker_predownload_test.go

    • Serena docker mode → container included
    • Serena local mode → container excluded
    • Serena + GitHub tool → both containers included

Example

Before this change, workflows using serena would pull the container on-demand:

# No serena container in predownload step
- name: Download container images
  run: bash /opt/gh-aw/actions/download_docker_images.sh ghcr.io/github/gh-aw-mcpg:v0.0.99

After:

# Serena container predownloaded alongside other images
- name: Download container images
  run: bash /opt/gh-aw/actions/download_docker_images.sh ghcr.io/github/gh-aw-mcpg:v0.0.99 ghcr.io/github/serena-mcp-server:latest
Original prompt

When the serena tool is enabled, the compiler needs to add the serena container image to the list of image container to predownload.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 3 commits February 5, 2026 17:03
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Add serena container image to predownload list Add serena container to predownload list when enabled Feb 5, 2026
Copilot AI requested a review from pelikhan February 5, 2026 17:13
@pelikhan pelikhan marked this pull request as ready for review February 5, 2026 17:17
Copilot AI review requested due to automatic review settings February 5, 2026 17:17
@pelikhan pelikhan merged commit 114fc25 into main Feb 5, 2026
50 of 51 checks passed
@pelikhan pelikhan deleted the copilot/add-serena-container-imag branch February 5, 2026 17:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds serena MCP container image predownloading support to reduce workflow startup delays. When serena is configured in docker mode (the default), its container is now included in the initial image download step alongside other required containers.

Changes:

  • Extended collectDockerImages() in pkg/workflow/docker.go to detect and include serena container when in docker mode (skips local mode which uses uvx instead)
  • Added comprehensive test coverage for serena predownload scenarios including docker mode, local mode, and multi-tool combinations
  • Updated all workflow lock files that use serena to include the container in their predownload steps

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.

File Description
pkg/workflow/docker.go Added serena container detection logic to collectDockerImages() with proper mode checking
pkg/workflow/docker_predownload_test.go Added three test cases covering serena docker mode, local mode, and combination scenarios
.github/workflows/*.lock.yml (19 files) Updated generated workflow files to include serena container in predownload step

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants