Fix smoke-claude: handle tool failures gracefully and guarantee safe output

[Copilot]

The smoke-claude workflow failed when the agentic-workflows tool returned errors, and didn't always create diagnostic issues on test failures. Timeout also exceeded the 10-minute target.

Changes

• Timeout: Reduced from 15 to 10 minutes
• agentic-workflows tool handling: Added explicit error handling with fallback behavior
  • If tool fails or returns no results, mark test as ❌ but continue execution
  • Clearer extraction instructions: total runs, success/failure counts, last run timestamp
• Safe output guarantee: Made issue creation mandatory regardless of test results
  • Added CRITICAL directive requiring issue creation before any other operations
  • Include error details in issue body when tests fail
  • Fallback for discussion comment step if discussion number extraction fails

Example

Before:

10. **Agentic Workflows MCP Testing**: 
   - Use the `agentic-workflows` MCP tool with the `status` method to query the status of the "smoke-claude" workflow
   - Extract key information: total runs, recent success/failure status, last run time

After:

10. **Agentic Workflows MCP Testing**: 
   - Call the `agentic-workflows` MCP tool using the `status` method with workflow name `smoke-claude`
   - If the tool returns an error or no results, mark this test as ❌ and note "Tool unavailable or workflow not found" but continue to the Output section
   - If the tool succeeds, extract key information from the response: total runs, success/failure counts, last run timestamp

Output section now explicitly requires issue creation:

**CRITICAL: You MUST create an issue regardless of test results - this is a required safe output.**

Original prompt

Fix smoke-claude to handle the agentic-workflows tool response and make sure it always create safe outputs. Increase timeout to 10 minutes.

See https://github.com/github/gh-aw/actions/runs/21757032307

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[pelikhan]

@copilot keep it 15

[Copilot]

Pull request overview

Updates the Smoke Claude agentic workflow to better handle agentic-workflows MCP tool responses (including error cases), reduce runtime timeout, and strengthen guidance to always produce required safe outputs.

Changes:

• Reduce smoke-claude workflow timeout from 15 to 10 minutes (and recompile lockfile).
• Improve agentic-workflows MCP tool testing instructions to handle errors gracefully and still proceed to safe outputs.
• Update output instructions to make issue creation mandatory regardless of test results.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
docs/src/content/docs/agent-factory-status.mdx	Removes a malformed/extra workflow row from the status table.
.github/workflows/smoke-claude.md	Updates timeout and strengthens instructions for MCP tool error handling + mandatory safe output issue creation.
.github/workflows/smoke-claude.lock.yml	Recompiled workflow YAML reflecting the updated timeout/frontmatter hash.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

In Output step 3, the instructions say to call add_comment with item_number set to the extracted discussion number. Elsewhere in this workflow (step 9) and in other smoke workflows, discussions are targeted via discussion_number, and using item_number risks posting to an issue/PR with the same number instead of the discussion. Consider switching this to discussion_number: <extracted_number> for consistency and correctness.

Suggested change

	3. Use the `add_comment` tool with `item_number` set to the discussion number you extracted in step 9 to add a **fun comic-book style comment** to that discussion - be playful and use comic-book language like "💥 WHOOSH!"
	3. Use the `add_comment` tool with `discussion_number` set to the discussion number you extracted in step 9 to add a **fun comic-book style comment** to that discussion - be playful and use comic-book language like "💥 WHOOSH!"