Rename MCP server identifier from agentic_workflows to agenticworkflows#14173
Rename MCP server identifier from agentic_workflows to agenticworkflows#14173
Conversation
- Add AgenticWorkflowsMCPServerID constant to pkg/constants/constants.go - Update MCP server name in pkg/workflow/mcp_config_builtin.go - Update MCP server name in pkg/workflow/mcp_renderer.go - Update test files to use new constant and name - Recompile all workflow lock files with new MCP server name Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Build successful - All unit tests passing - All 146 workflows compiled successfully - Linting and formatting checks passed Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
❌ Changeset Generator failed. Please review the logs for details. |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
🌑 The shadows whisper... Smoke Codex failed. The oracle requires further meditation... |
Agent Container Tool Check
Result: 11/12 tools fully functional, 1 with execution issue Status:
|
|
🤖 Beep boop! The smoke test agent dropped by to say hi! 👋 Just finished checking all systems for Run §21758499053 and everything's looking groovy! ✨ P.S. - I also left some test artifacts in /tmp and triggered a haiku printer workflow. Living my best automated life! 🎉
|
Smoke Test Results
Overall Status: PASS ✅ cc @pelikhan
|
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
Smoke Test Results ✅PR Titles:
Test Results:
Overall Status: PASS
|
There was a problem hiding this comment.
Pull request overview
Renames the internal MCP server identifier for agentic-workflows from agentic_workflows to agenticworkflows and centralizes it in a constant to avoid underscore/case ambiguity.
Changes:
- Added
constants.AgenticWorkflowsMCPServerIDand updated renderers to use it. - Updated unit tests to assert the new identifier.
- Regenerated workflow lock files to reflect the new MCP server key.
Reviewed changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/mcp_renderer_test.go | Updates renderer tests to assert the new MCP server identifier (partly via constant). |
| pkg/workflow/mcp_renderer.go | Updates TOML rendering to use the new server identifier constant. |
| pkg/workflow/mcp_config_refactor_test.go | Updates expected MCP config outputs to use the new identifier. |
| pkg/workflow/mcp_config_builtin.go | Updates built-in MCP config generation and examples to use the constant/new identifier. |
| pkg/workflow/importable_tools_test.go | Updates compiled workflow assertions to match the new identifier (uses constant in one assertion). |
| pkg/workflow/agentic_workflow_test.go | Updates engine MCP config generation assertions to match the new identifier (uses constant). |
| pkg/constants/constants.go | Adds AgenticWorkflowsMCPServerID constant (agenticworkflows). |
| docs/src/content/docs/agent-factory-status.mdx | Updates the agent/workflow status listing (adds/removes entries). |
| .github/workflows/workflow-normalizer.lock.yml | Regenerates lock workflow content to use agenticworkflows key. |
| .github/workflows/static-analysis-report.lock.yml | Regenerates lock workflow content to use agenticworkflows key. |
| .github/workflows/smoke-copilot.lock.yml | Regenerates lock workflow content to use agenticworkflows key. |
| .github/workflows/smoke-claude.lock.yml | Regenerates lock workflow content to use agenticworkflows key. |
| .github/workflows/security-review.lock.yml | Regenerates lock workflow content to use agenticworkflows key. |
| .github/workflows/safe-output-health.lock.yml | Regenerates lock workflow content to use agenticworkflows key. |
| .github/workflows/q.lock.yml | Regenerates lock workflow content to use agenticworkflows key. |
| .github/workflows/python-data-charts.lock.yml | Regenerates lock workflow content to use agenticworkflows key. |
| .github/workflows/prompt-clustering-analysis.lock.yml | Regenerates lock workflow content to use agenticworkflows key. |
| .github/workflows/portfolio-analyst.lock.yml | Regenerates lock workflow content to use agenticworkflows key. |
| .github/workflows/metrics-collector.lock.yml | Regenerates lock workflow content to use agenticworkflows key. |
| .github/workflows/mcp-inspector.lock.yml | Regenerates lock workflow content to use agenticworkflows key. |
| .github/workflows/example-workflow-analyzer.lock.yml | Regenerates lock workflow content to use agenticworkflows key. |
| .github/workflows/dev-hawk.lock.yml | Regenerates lock workflow content to use agenticworkflows key. |
| .github/workflows/deep-report.lock.yml | Regenerates lock workflow content to use agenticworkflows key in both TOML and JSON blocks. |
| .github/workflows/daily-safe-output-optimizer.lock.yml | Regenerates lock workflow content to use agenticworkflows key. |
| .github/workflows/daily-observability-report.lock.yml | Regenerates lock workflow content to use agenticworkflows key in both TOML and JSON blocks. |
| .github/workflows/daily-firewall-report.lock.yml | Regenerates lock workflow content to use agenticworkflows key. |
| .github/workflows/daily-cli-tools-tester.lock.yml | Regenerates lock workflow content to use agenticworkflows key. |
| .github/workflows/cloclo.lock.yml | Regenerates lock workflow content to use agenticworkflows key. |
| .github/workflows/audit-workflows.lock.yml | Regenerates lock workflow content to use agenticworkflows key. |
| .github/workflows/agent-persona-explorer.lock.yml | Regenerates lock workflow content to use agenticworkflows key. |
| .github/workflows/agent-performance-analyzer.lock.yml | Regenerates lock workflow content to use agenticworkflows key. |
Comments suppressed due to low confidence (1)
pkg/workflow/mcp_renderer_test.go:1
- The assertion is parameterized via
constants.AgenticWorkflowsMCPServerID, but the failure message is hardcoded toagenticworkflows. To prevent the message from drifting if the constant changes, include the constant value in the error (e.g.,t.Errorf("Expected %q server ID", constants.AgenticWorkflowsMCPServerID)).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | [Copilot Session Insights](https://github.com/github/gh-aw/blob/main/.github/workflows/copilot-session-insights.md) | claude | [](https://github.com/github/gh-aw/actions/workflows/copilot-session-insights.lock.yml) | - | - | | ||
| | [Daily Choice Type Test](https://github.com/github/gh-aw/blob/main/.github/workflows/daily-choice-test.md) | claude | [](https://github.com/github/gh-aw/actions/workflows/daily-choice-test.lock.yml) | `0 12 * * 1-5` | - | | ||
| | [Daily CLI Performance Agent](https://github.com/github/gh-aw/blob/main/.github/workflows/daily-cli-performance.md) | copilot | [](https://github.com/github/gh-aw/actions/workflows/daily-cli-performance.lock.yml) | - | - | | ||
| | [Daily CLI Tools Exploratory Tester](https://github.com/github/gh-aw/blob/main/.github/workflows/daily-cli-tools-tester.md) | copilot | [](https://github.com/github/gh-aw/actions/workflows/daily-cli-tools-tester.lock.yml) | - | - | |
There was a problem hiding this comment.
This PR’s stated purpose is renaming the MCP server identifier, but this doc change also adds a new workflow entry and removes the “Security Fix PR” entry. If these are intentional, it would help to mention them in the PR description; otherwise, consider moving them to a separate PR to keep the rename change isolated.
| | [Security Compliance Campaign](https://github.com/github/gh-aw/blob/main/.github/workflows/security-compliance.md) | copilot | [](https://github.com/github/gh-aw/actions/workflows/security-compliance.lock.yml) | - | - | | ||
| | [Security Fix PR](https://github.com/github/gh-aw/blob/main/.github/workflows/security-fix-pr.md) | copilot | [](https://github.com/github/gh-aw/actions/workflows/security-fix-pr.lock.yml) | - | - | | ||
| | [Security Guard Agent 🛡️](https://github.com/github/gh-aw/blob/main/.github/workflows/security-guard.md) | copilot | [](https://github.com/github/gh-aw/actions/workflows/security-guard.lock.yml) | - | - | |
There was a problem hiding this comment.
This PR’s stated purpose is renaming the MCP server identifier, but this doc change also adds a new workflow entry and removes the “Security Fix PR” entry. If these are intentional, it would help to mention them in the PR description; otherwise, consider moving them to a separate PR to keep the rename change isolated.
MCP server identifiers use single-word lowercase naming (
safeoutputs,safeinputs). Theagentic_workflowsidentifier was inconsistent and prone to underscore/uppercase ambiguity.Changes
AgenticWorkflowsMCPServerID = "agenticworkflows"inpkg/constants/constants.gomcp_config_builtin.goandmcp_renderer.goto use constant instead of hardcoded stringsagenticworkflowsidentifierExample
Before:
{ "mcpServers": { "agentic_workflows": { "type": "stdio", "container": "alpine:latest" } } }After:
{ "mcpServers": { "agenticworkflows": { "type": "stdio", "container": "alpine:latest" } } }The user-facing tool name in frontmatter remains
agentic-workflows(with hyphen). Only the internal MCP server identifier changes.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.