Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…-04b4-4d43-8eb1-dd06211f2ce3
There was a problem hiding this comment.
Pull request overview
Updates integration tests and generated workflow artifacts/lockfiles to align with the AWF v0.13.12 bump and avoid test false-positives caused by unrelated version strings in compiled workflow output.
Changes:
- Tighten
TestRuntimeSetupPreservesUserVersionsassertions to look for explicitpython-versiondeclarations rather than a generic"3.12"substring. - Bump AWF versions/tags in workflow lockfiles from
v0.13.7/0.13.7tov0.13.12/0.13.12. - Regenerate
specs/artifacts.mdto reflect updated workflow inventory and artifact paths (including/tmp/gh-aw/agent/).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
pkg/workflow/runtime_setup_integration_test.go |
Fixes the failing runtime setup integration test by using a more specific match for the default Python version. |
.github/workflows/dependabot-project-manager.lock.yml |
Updates AWF binary/image tags to v0.13.12 in the locked workflow. |
.github/workflows/daily-cli-tools-tester.lock.yml |
Updates AWF binary/image tags to v0.13.12 in the locked workflow. |
specs/artifacts.md |
Regenerates artifact location reference to include current workflow usage and paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Should not add default version (3.12) - check specifically for python-version to avoid | ||
| // false positives from other version strings like AWF version "0.13.12" | ||
| if strings.Contains(lockContent, `python-version: '3.12'`) || strings.Contains(lockContent, `python-version: "3.12"`) { | ||
| t.Error("Should not override user's version with default version") |
There was a problem hiding this comment.
The negative assertion only checks for quoted forms of 3.12. If the lockfile emitter ever outputs python-version: 3.12 (unquoted) this test would miss the regression. Consider matching python-version: with optional quotes/whitespace (e.g., via regexp) and/or reusing the non-comment-line helpers so the check is robust to YAML formatting changes.
| - name: Install GitHub Copilot CLI | ||
| run: /opt/gh-aw/actions/install_copilot_cli.sh 0.0.405 | ||
| - name: Install awf binary | ||
| run: bash /opt/gh-aw/actions/install_awf_binary.sh v0.13.7 | ||
| run: bash /opt/gh-aw/actions/install_awf_binary.sh v0.13.12 |
There was a problem hiding this comment.
PR description focuses on the integration test change, but this file also bumps AWF/runtime image versions (v0.13.7 -> v0.13.12). Please call out these workflow lock updates explicitly in the PR description (or split into a separate PR) so reviewers understand the full scope of the change.
Test
TestRuntimeSetupPreservesUserVersionswas failing after AWF bump to v0.13.12. The test usedstrings.Contains(lockContent, "3.12")to detect if default Python 3.12 was incorrectly added, but this matched AWF version "0.13.12" in the compiled workflow.Change
Updated test to check for explicit Python version declarations:
The test now correctly validates user-specified Python versions are preserved without false positives from unrelated version strings.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.