Skip to content

Fix strict mode tests using deprecated anonymous bash syntax #14242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Feb 7, 2026
+2 −2
Merged

Fix strict mode tests using deprecated anonymous bash syntax #14242

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aac9b99
Initial plan
Copilot Feb 6, 2026
896ad27
Fix failing tests by replacing anonymous bash: syntax with bash: []
Copilot Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/workflow/strict_mode_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ engine: copilot
tools:
github:
allowed: [issue_read]
bash:
bash: []
---

# Test Workflow`,
Expand Down Expand Up @@ -463,7 +463,7 @@ permissions:
timeout-minutes: 10
engine: copilot
tools:
bash:
bash: []
network:
allowed:
Comment on lines 464 to 468
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this test case, the name says "bash null allowed in strict mode", but the YAML now uses bash: [] (empty list) and is identical to the next test case ("bash empty array allowed..."). This means the suite no longer covers the bash: null / anonymous bash: scenario, which is expected to be invalid per validateBashToolConfig. Consider either renaming/removing this case, or changing it to explicitly test bash: null and assert an error.

Copilot uses AI. Check for mistakes.
- "api.example.com"
Expand Down
Loading