[Code Quality] Centralize ANSI escape sequences in pkg/console/terminal.go

[Copilot]

This PR centralizes all ANSI escape sequences into pkg/console/terminal.go to improve code maintainability and consistency.

Changes Made

• Moved terminal control functions: Relocated ClearScreen() and ClearLine() from console.go to terminal.go
• Centralized location: All terminal control functions now reside in terminal.go:
  • ClearScreen() - clears terminal screen
  • ClearLine() - clears current line
  • MoveCursorUp(n int) - moves cursor up n lines
  • MoveCursorDown(n int) - moves cursor down n lines
• ANSI constants defined:
  • ansiClearScreen = "\033[H\033[2J"
  • ansiClearLine = "\033[K"
  • ansiCarriageReturn = "\r"
• Consistent TTY detection: All functions check tty.IsStderrTerminal() before emitting ANSI codes to prevent codes in non-TTY environments

Files Modified

• pkg/console/terminal.go - Added ClearScreen() and ClearLine() functions
• pkg/console/console.go - Removed ClearScreen() and ClearLine() functions

Benefits

• Improved maintainability: Single source of truth for terminal control operations
• Consistency: All ANSI codes defined as constants in one file
• Bug prevention: TTY detection uniformly applied across all functions
• Easier refactoring: Future changes only need to be made in terminal.go

Testing

• ✅ All unit tests pass
• ✅ Code formatting validated
• ✅ Linting passes
• ✅ Code review found no issues
• ✅ Functions used correctly in console.go, spinner.go, and add_interactive_orchestrator.go

The implementation fully meets all success criteria from the issue: all manual ANSI escape sequences are now replaced with helper functions, TTY detection is consistently applied, and the code is more maintainable.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[Code Quality] Centralize ANSI escape sequences in pkg/console/terminal.go</issue_title>
<issue_description>## Description

The codebase currently has 8 instances of manual ANSI escape sequences scattered across different files. These should be centralized into helper functions in a new pkg/console/terminal.go file to improve maintainability, consistency, and prevent TTY detection bugs.

Current Problem

Manual ANSI codes are duplicated in multiple locations:

• pkg/cli/add_interactive_orchestrator.go: \033[H\033[2J (clear screen)
• pkg/console/console.go: \033[2J\033[H (clear screen)
• pkg/console/console.go: \r\033[K (clear line)
• pkg/console/spinner.go: Multiple instances of \r\033[K

This leads to:

• Code duplication and inconsistency
• Missing TTY detection in some cases
• Harder to maintain and update
• Potential bugs if ANSI codes need changes

Suggested Changes

Create pkg/console/terminal.go with helper functions:

package console

import (
    "fmt"
    "os"
    "github.com/github/gh-aw/pkg/tty"
)

// ClearScreen clears the terminal screen if stderr is a TTY
func ClearScreen() {
    if tty.IsStderrTerminal() {
        fmt.Fprint(os.Stderr, "\033[H\033[2J")
    }
}

// ClearLine clears the current line if stderr is a TTY
func ClearLine() {
    if tty.IsStderrTerminal() {
        fmt.Fprint(os.Stderr, "\r\033[K")
    }
}

// MoveCursorUp moves cursor up n lines if stderr is a TTY
func MoveCursorUp(n int) {
    if tty.IsStderrTerminal() {
        fmt.Fprintf(os.Stderr, "\033[%dA", n)
    }
}

// MoveCursorDown moves cursor down n lines if stderr is a TTY
func MoveCursorDown(n int) {
    if tty.IsStderrTerminal() {
        fmt.Fprintf(os.Stderr, "\033[%dB", n)
    }
}

Then replace all manual ANSI code usage with these helpers.

Files Affected

• New file: pkg/console/terminal.go
• pkg/cli/add_interactive_orchestrator.go
• pkg/console/console.go
• pkg/console/spinner.go

Success Criteria

• All manual ANSI escape sequences replaced with helper functions
• TTY detection consistently applied across all terminal control operations
• No regressions in terminal output behavior
• Code is more maintainable and easier to understand
• All existing tests pass

Source

Extracted from Terminal Stylist Report: Console Output Analysis (Discussion #12889)

Priority

High - Improves code organization and prevents potential TTY detection bugs. Quick win with small effort (1-2 hours).

AI generated by Discussion Task Miner - Code Quality Improvement Agent

• expires on Feb 8, 2026, 1:18 PM UTC

Comments on the Issue (you are @copilot in this section)

• Fixes [Code Quality] Centralize ANSI escape sequences in pkg/console/terminal.go #14336

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[pelikhan]

@copilot work

[Copilot]

@copilot work

I've completed centralizing the ANSI escape sequences in pkg/console/terminal.go.

Changes made (commit 73c481b):

• Moved ClearScreen() and ClearLine() from console.go to terminal.go
• All terminal control functions now centralized in terminal.go
• All functions use TTY detection consistently
• Tests pass and code review shows no issues

All ANSI escape sequences are now in one location with helper functions, making the code more maintainable and preventing TTY detection bugs.

[Copilot]

Pull request overview

This PR centralizes terminal control behavior by moving ClearScreen() and ClearLine() into pkg/console/terminal.go, consolidating ANSI escape usage and ensuring consistent TTY gating for terminal control output.

Changes:

• Added ClearScreen() and ClearLine() helpers to pkg/console/terminal.go alongside existing cursor movement helpers.
• Removed ClearScreen() and ClearLine() from pkg/console/console.go to avoid duplication.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
pkg/console/terminal.go	Adds ClearScreen() and ClearLine() implementations using centralized ANSI constants and tty.IsStderrTerminal() gating.
pkg/console/console.go	Removes duplicated ClearScreen() / ClearLine() now hosted in terminal.go.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.