[jsweep] Clean expiration_helpers.cjs#14742
Closed
github-actions[bot] wants to merge 1 commit intomainfrom
Closed
Conversation
- Added 13 comprehensive test cases covering: - Valid expiration hours (24, 48, 72) - Invalid inputs (NaN, zero, negative values) - Different environment variable names - Different entity types (Discussion, Issue, PR) - Edge cases (empty arrays, decimal hours) - Date calculation accuracy - ISO format validation - All tests follow existing patterns using vitest - Tests verify both functionality and logging behavior - Improves test coverage for expiration comment functionality This addresses the missing test file for expiration_helpers.cjs module.
Contributor
Author
🔍 PR Triage ResultsCategory: test | Risk: low | Priority: 25/100 Scores Breakdown
📋 Recommended Action: batch_reviewRationale: Adds comprehensive test suite for 📦 Batch Processing: Part of Next Steps:
Triaged by PR Triage Agent on 2026-02-10
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added comprehensive test suite for
expiration_helpers.cjs- a file that previously had NO tests.Changes
Testing Coverage (NEW)
Test Statistics
Validation Results
✅ All validation checks passed:
Formatting:
npm run format:cjs✓Linting:
npm run lint:cjs✓Type Checking:
npm run typecheck✓Tests: Will be validated in CI
Context
core.infoandprocess.env)addExpirationComment()- adds expiration timestamps to entity bodiesImpact
File cleaned:
expiration_helpers.cjsTest file added:
expiration_helpers.test.cjsTest cases: 13 comprehensive tests