Skip to content

[WIP] Fix failing GitHub Actions workflow Integration: Workflow Compiler #14792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Feb 10, 2026
Merged

[WIP] Fix failing GitHub Actions workflow Integration: Workflow Compiler #14792

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aafd11c
Initial plan
Copilot Feb 10, 2026
6d24bef
Update action pin SHAs in runtime integration tests
Copilot Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/workflow/runtime_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ Test workflow with runtime overrides applied to steps.
lockStr := string(lockContent)

// Verify that Node.js setup step is included with version 22
if !strings.Contains(lockStr, "actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f") {
if !strings.Contains(lockStr, "actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238") {
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These integration assertions hardcode the pinned commit SHA. This has already proven brittle when action_pins.json changes; consider deriving the expected SHA via the same pin-resolution code used by the compiler (e.g., resolve actions/setup-node@v6 through GetActionPinWithData / pins data) and asserting against that value instead of an inlined hash.

This issue also appears on line 358 of the same file.

Suggested change
if !strings.Contains(lockStr, "actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238") {
if !strings.Contains(lockStr, "actions/setup-node@") {

Copilot uses AI. Check for mistakes.
t.Error("Expected setup-node action in lock file")
}
if !strings.Contains(lockStr, "node-version: '22'") {
Expand Down Expand Up @@ -355,7 +355,7 @@ Test workflow that uses Go without go.mod file.
if !strings.Contains(lockStr, "Setup Go") {
t.Error("Expected 'Setup Go' step in lock file")
}
if !strings.Contains(lockStr, "actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c") {
if !strings.Contains(lockStr, "actions/setup-go@7a3fe6cf4cb3a834922a1244abfce67bcef6a0c5") {
t.Error("Expected actions/setup-go action in lock file")
}
if !strings.Contains(lockStr, "go-version: '1.25'") {
Expand Down
Loading