Skip to content

Comments

Fix test fixture using deprecated timeout_minutes field#14885

Merged
pelikhan merged 2 commits intomainfrom
copilot/fix-timeout-minutes-integration
Feb 11, 2026
Merged

Fix test fixture using deprecated timeout_minutes field#14885
pelikhan merged 2 commits intomainfrom
copilot/fix-timeout-minutes-integration

Conversation

Copy link
Contributor

Copilot AI commented Feb 11, 2026

The max_turns_test.go integration test used timeout_minutes (underscore), which was removed from the schema in favor of timeout-minutes (hyphen). The compiler rejected the fixture before test assertions could execute, causing CI failure in "Integration: Workflow Misc Part 2".

Changes

  • Updated test fixture in pkg/workflow/max_turns_test.go line 79: timeout_minutes: 15timeout-minutes: 15
 engine:
   id: claude
   max-turns: 10
-timeout_minutes: 15
+timeout-minutes: 15
 strict: false

This aligns the test with the current schema, which only recognizes the hyphenated form.

Original prompt

This section details on the original issue you should resolve

<issue_title>[CI Failure Doctor] Timeout_minutes trigger integration misc failure</issue_title>
<issue_description># 🏥 CI Failure Investigation - Run github/gh-aw#34788

Summary

The Integration: Workflow Misc Part 2 job now fails because pkg/workflow/max_turns_test.go still compiles a workflow that uses the removed timeout_minutes field, so the workflow compiler rejects it before the test assertions ever run.

Failure Details

Root Cause Analysis

The schema no longer allows timeout_minutes, so the fixture under test (lines 8‑11 of max_turns_test.go) triggers a compilation error (Unknown property: timeout_minutes) when the compiler parses the workflow frontmatter. The test never gets to the assertions that would verify max-turns behavior.

Failed Jobs and Errors

  • Integration: Workflow Misc Part 2pkg/workflow/max_turns_test.go fails because the workflow file contains timeout_minutes: 15, which the compiler rejects with error: Unknown property: timeout_minutes. Did you mean 'timeout-minutes'?.

Investigation Findings

  • The only failing job is the integration suite for workflow misc components, and its log points directly to the fixture in max_turns_test.go.
  • The frontmatter in that test was not updated after the schema migration that removed timeout_minutes in favor of timeout-minutes.
  • Local reproduction attempts were blocked: go test ./pkg/workflow -run TestMaxTurnsCompilation tried to download Go 1.25.0 and received Forbidden, and forcing GOTOOLCHAIN=local hit go.mod requires go >= 1.25.0 (running go 1.24.12).

Recommended Actions

  • Update pkg/workflow/max_turns_test.go and any other fixtures that try to set timeout_minutes so they use timeout-minutes (and rerun math-turns coverage just to be safe).
  • Re-run the Integration: Workflow Misc Part 2 job once the fixture is updated.
  • Ensure the runners (or dev laptops) can access Go 1.25.0 (allow proxy downloads or pre-install the toolchain) so tests can be re-run locally without hitting go.mod requirements.

Prevention Strategies

  • Consider adding a lint or test that fails early when new fixtures use deprecated frontmatter keys such as timeout_minutes.
  • Keep documentation (e.g., docs/guides/upgrading.md and frontmatter reference pages) and codemods synchronized with schema removals, and search for the old key when changing schemas.

AI Team Self-Improvement

  • When a frontmatter property is removed, update every fixture/test that uses it before rerunning the workflows and codemods that touch that property.
  • Include Go toolchain availability notes in your checklist so local go test runs report actionable errors instead of getting blocked by go1.25.0 downloads.

Historical Context

  • The timeout_minutes field was previously removed from the schema and documented in docs/src/content/docs/guides/upgrading.md and the frontmatter reference guide, so this is a regression for the integration watchdog.

AI generated by CI Failure Doctor

To add this workflow in your repository, run gh aw add githubnext/agentics/workflows/ci-doctor.md@ea350161ad5dcc9624cf510f134c6a9e39a6f94d. See usage guide.

  • expires on Feb 12, 2026, 4:41 AM UTC

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix CI failure due to removed timeout_minutes field Fix test fixture using deprecated timeout_minutes field Feb 11, 2026
Copilot AI requested a review from pelikhan February 11, 2026 04:53
@pelikhan pelikhan marked this pull request as ready for review February 11, 2026 04:57
Copilot AI review requested due to automatic review settings February 11, 2026 04:57
@pelikhan pelikhan merged commit 88cda73 into main Feb 11, 2026
1 check passed
@pelikhan pelikhan deleted the copilot/fix-timeout-minutes-integration branch February 11, 2026 04:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a CI failure in the "Integration: Workflow Misc Part 2" job by updating a test fixture to use the correct schema field name. The test fixture in max_turns_test.go was using the deprecated timeout_minutes (underscore) field, which was removed from the schema in favor of timeout-minutes (hyphen). This caused the workflow compiler to reject the fixture with an "Unknown property" error before the test assertions could execute.

Changes:

  • Updated test fixture in pkg/workflow/max_turns_test.go to use timeout-minutes instead of timeout_minutes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI Failure Doctor] Timeout_minutes trigger integration misc failure

2 participants