Remove integration build constraint from pkg/fileutil#14892
Merged
pelikhan merged 2 commits intocopilot/standardize-path-validation-patternsfrom Feb 11, 2026
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issues in existing tests
Remove integration build constraint from pkg/fileutil
Feb 11, 2026
pelikhan
merged commit 7cebdb2
into
copilot/standardize-path-validation-patterns
3 checks passed
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an !integration build constraint from pkg/fileutil/fileutil.go so the fileutil package remains available during integration-tagged builds, preventing downstream compile failures (e.g., pkg/cli importing fileutil).
Changes:
- Removed
//go:build !integrationfrompkg/fileutil/fileutil.goso the package is included in integration builds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration tests failed to compile because
pkg/fileutil/fileutil.gohad a//go:build !integrationconstraint, excluding the entire package from integration test builds. Any package importing fileutil (e.g.,pkg/cli) would fail with:Changes
//go:build !integrationfrompkg/fileutil/fileutil.gofileutil_test.go(unit tests should not run during integration tests)Rationale
Utility packages providing core functionality like path validation must be available in all build configurations. Build constraints belong on test files, not on source files that other packages depend on.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.