Remove debug step from conclusion job generation#15020
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Removes the generated “Debug job inputs” step from conclusion job generation so conclusion jobs no longer echo internal environment values, and regenerates the workflow lockfiles to reflect the updated generator output.
Changes:
- Removed the “Debug job inputs” step generation from
buildConclusionJob()inpkg/workflow/notify_comment.go. - Regenerated workflow
.lock.ymlfiles to remove the corresponding step from all conclusion jobs. - (Unrelated) One lockfile also changes
GH_AW_RATE_LIMIT_EVENTSvalue ordering.
Reviewed changes
Copilot reviewed 143 out of 143 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/notify_comment.go | Removes generation of the “Debug job inputs” step in conclusion jobs. |
| .github/workflows/agent-performance-analyzer.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/agent-persona-explorer.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/ai-moderator.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/archie.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/artifacts-summary.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/audit-workflows.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/auto-triage-issues.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step; also changes GH_AW_RATE_LIMIT_EVENTS ordering. |
| .github/workflows/blog-auditor.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/bot-detection.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/brave.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/breaking-change-checker.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/changeset.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/chroma-issue-indexer.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/ci-coach.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/ci-doctor.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/claude-code-user-docs-review.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/cli-consistency-checker.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/cli-version-checker.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/cloclo.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/code-scanning-fixer.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/code-simplifier.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/codex-github-remote-mcp-test.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/commit-changes-analyzer.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/copilot-agent-analysis.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/copilot-cli-deep-research.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/copilot-pr-merged-report.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/copilot-pr-nlp-analysis.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/copilot-pr-prompt-analysis.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/copilot-session-insights.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/craft.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-assign-issue-to-user.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-choice-test.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-cli-performance.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-cli-tools-tester.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-code-metrics.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-compiler-quality.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-copilot-token-report.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-doc-updater.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-fact.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-file-diet.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-firewall-report.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-issues-report.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-malicious-code-scan.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-mcp-concurrency-analysis.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-multi-device-docs-tester.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-news.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-observability-report.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-performance-summary.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-regulatory.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-repo-chronicle.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-safe-output-optimizer.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-secrets-analysis.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-semgrep-scan.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-syntax-error-quality.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-team-evolution-insights.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-team-status.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-testify-uber-super-expert.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/daily-workflow-updater.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/deep-report.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/delight.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/dependabot-burner.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/dependabot-go-checker.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/dev-hawk.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/dev.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/developer-docs-consolidator.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/dictation-prompt.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/discussion-task-miner.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/docs-noob-tester.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/draft-pr-cleanup.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/duplicate-code-detector.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/example-custom-error-patterns.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/example-permissions-warning.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/example-workflow-analyzer.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/firewall-escape.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/firewall.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/functional-pragmatist.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/github-mcp-structural-analysis.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/github-mcp-tools-report.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/github-remote-mcp-auth-test.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/glossary-maintainer.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/go-fan.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/go-logger.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/go-pattern-detector.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/gpclean.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/grumpy-reviewer.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/hourly-ci-cleaner.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/instructions-janitor.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/issue-arborist.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/issue-classifier.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/issue-monster.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/issue-triage-agent.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/jsweep.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/layout-spec-maintainer.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/lockfile-stats.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/mcp-inspector.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/mergefest.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/metrics-collector.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/notion-issue-summary.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/org-health-report.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/pdf-summary.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/plan.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/poem-bot.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/portfolio-analyst.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/pr-nitpick-reviewer.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/pr-triage-agent.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/prompt-clustering-analysis.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/python-data-charts.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/q.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/release.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/repo-audit-analyzer.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/repo-tree-map.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/repository-quality-improver.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/research.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/safe-output-health.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/schema-consistency-checker.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/scout.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/security-compliance.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/security-guard.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/security-review.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/semantic-function-refactor.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/sergo.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/slide-deck-maintainer.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/smoke-claude.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/smoke-codex.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/smoke-copilot.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/smoke-opencode.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/smoke-project.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/smoke-test-tools.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/stale-repo-identifier.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/static-analysis-report.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/step-name-alignment.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/sub-issue-closer.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/super-linter.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/technical-doc-writer.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/terminal-stylist.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/test-create-pr-error-handling.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/test-dispatcher.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/test-project-url-default.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/test-workflow.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/tidy.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/typist.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/ubuntu-image-analyzer.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/unbloat-docs.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/video-analyzer.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/weekly-issue-summary.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/workflow-generator.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/workflow-health-manager.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/workflow-normalizer.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
| .github/workflows/workflow-skill-extractor.lock.yml | Regenerated lockfile to remove the “Debug job inputs” step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| GH_AW_RATE_LIMIT_MAX: "5" | ||
| GH_AW_RATE_LIMIT_WINDOW: "60" | ||
| GH_AW_RATE_LIMIT_EVENTS: "workflow_dispatch,issues" | ||
| GH_AW_RATE_LIMIT_EVENTS: "issues,workflow_dispatch" |
There was a problem hiding this comment.
The PR description says the only workflow change is removing the generated "Debug job inputs" step, but this file also changes GH_AW_RATE_LIMIT_EVENTS ordering ("workflow_dispatch,issues" -> "issues,workflow_dispatch"). If this reordering is unintended, please revert it to keep the PR scoped; if it is intended, consider mentioning it in the PR description since it affects the generated workflow output.
Removes the "Debug job inputs" step that was generated in all conclusion jobs. This step echoed environment variables (comment_id, comment_repo, agent output types, and agent conclusion) that provided no operational value.
Changes
pkg/workflow/notify_comment.go: Removed 11 lines generating debug step inbuildConclusionJob().lock.ymlfiles without the debug stepBefore
After
Step no longer generated. Conclusion jobs now proceed directly to artifact download.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.