-
Notifications
You must be signed in to change notification settings - Fork 225
Standardize agent output summary title to "Agentic Conversation" #15072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
69fddfa
4e25222
3dc0490
285b22b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2095,7 +2095,7 @@ describe("log_parser_shared.cjs", () => { | |
| const result = wrapAgentLogInSection(markdown, { parserName: "Copilot" }); | ||
|
|
||
| expect(result).toContain("<details open>"); | ||
| expect(result).toContain("<summary>🤖 Copilot CLI Session</summary>"); | ||
| expect(result).toContain("<summary>Agentic Conversation</summary>"); | ||
| expect(result).toContain(markdown); | ||
| expect(result).toContain("</details>"); | ||
| }); | ||
|
|
@@ -2106,7 +2106,7 @@ describe("log_parser_shared.cjs", () => { | |
| const markdown = "Test content"; | ||
| const result = wrapAgentLogInSection(markdown, { parserName: "Claude" }); | ||
|
|
||
| expect(result).toContain("🤖 Claude CLI Session"); | ||
| expect(result).toContain("Agentic Conversation"); | ||
|
Comment on lines
2106
to
+2109
|
||
| }); | ||
|
|
||
| it("should allow closed state when open is false", async () => { | ||
|
|
@@ -2125,7 +2125,7 @@ describe("log_parser_shared.cjs", () => { | |
| const markdown = "Test content"; | ||
| const result = wrapAgentLogInSection(markdown); | ||
|
|
||
| expect(result).toContain("🤖 Agent CLI Session"); | ||
| expect(result).toContain("Agentic Conversation"); | ||
| }); | ||
|
|
||
| it("should return empty string for empty or undefined markdown", async () => { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrapAgentLogInSectionnow hard-codes the summary title, soparserName(and its JSDoc describing it) no longer affects output. To avoid confusion for future maintainers, please update the function contract to reflect this (e.g., noteparserNameis accepted only for backward compatibility and ignored, or rename the destructured variable to_parserName/ remove it from destructuring while still accepting it inoptions).