Skip to content

Add build setup to Daily Syntax Error Quality Check workflow #15095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Feb 12, 2026
+34 −1
Merged

Add build setup to Daily Syntax Error Quality Check workflow #15095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b14c6bb
Initial plan
Copilot Feb 12, 2026
4997094
Add build setup steps to Daily Syntax Error Quality Check workflow
Copilot Feb 12, 2026
ca229d2
Use go-version-file instead of hardcoded Go version
Copilot Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/aw/actions-lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,11 @@
"version": "v4.3.1",
"sha": "67a3573c9a986a3f9c594539f4ab511d57bb3ce9"
},
"actions/setup-go@v5": {
"repo": "actions/setup-go",
"version": "v5",
"sha": "40f1582b2485089dde7abd97c1529aa768e1baff"
},
Comment on lines +68 to +72
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/setup-go@v5 was added to the action lock entries. If the workflow is updated to use actions/setup-go@v6 like the rest of the repo, this extra v5 entry should be unnecessary; consider removing it (via re-running the lock regeneration) to keep the lockfile minimal and consistent.

Suggested change
"actions/setup-go@v5": {
"repo": "actions/setup-go",
"version": "v5",
"sha": "40f1582b2485089dde7abd97c1529aa768e1baff"
},

Copilot uses AI. Check for mistakes.
"actions/setup-go@v6.2.0": {
"repo": "actions/setup-go",
"version": "v6.2.0",
Expand Down
15 changes: 14 additions & 1 deletion .github/workflows/daily-syntax-error-quality.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions .github/workflows/daily-syntax-error-quality.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,21 @@ safe-outputs:
close-older-issues: true
timeout-minutes: 20
strict: true
steps:
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version-file: go.mod
cache: true
Comment on lines +34 to +38
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo’s workflow frontmatter generally uses actions/setup-go@v6 (and CI uses setup-go v6) with go-version-file: go.mod. Using @v5 here is inconsistent and also forces an extra actions-lock.json entry; switching to @v6 should align with the rest of the workflows and the existing lock for v6.2.0.

Copilot uses AI. Check for mistakes.

- name: Build gh-aw
run: |
make build

Comment on lines +39 to +43
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are trailing spaces on otherwise-blank lines in the new steps: block (after cache: true and after make build). Please remove the trailing whitespace to avoid churn in future diffs and to satisfy editors/linters that trim whitespace.

Suggested change
- name: Build gh-aw
run: |
make build
- name: Build gh-aw
run: |
make build

Copilot uses AI. Check for mistakes.
- name: Verify gh-aw installation
run: |
./gh-aw --version
echo "gh-aw binary is ready at ./gh-aw"
Comment on lines +44 to +47
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The agent instructions later cd /tmp/... and run ./gh-aw compile ...; after that cd, ./gh-aw won’t exist unless the binary is copied there or added to PATH. Consider adding a step to add $GITHUB_WORKSPACE to $GITHUB_PATH (and then invoke gh-aw), or adjust the instructions/commands to use an absolute path like $GITHUB_WORKSPACE/gh-aw.

Copilot uses AI. Check for mistakes.
imports:
- shared/mood.md
- shared/reporting.md
Expand Down