Skip to content

[WIP] Fix issues in tests #15146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Feb 12, 2026
Merged

[WIP] Fix issues in tests #15146

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b5b1e7
Initial plan
Copilot Feb 12, 2026
f22b15f
Fix test expectations for GITHUB_ACTOR support
Copilot Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions pkg/workflow/mcp_config_refactor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,12 +279,12 @@ func TestRenderAgenticWorkflowsMCPConfigTOML(t *testing.T) {
expectedContainer: `container = "alpine:latest"`,
shouldHaveEntrypoint: true,
expectedMounts: []string{
`entrypoint = "/opt/gh-aw/gh-aw"`, // Entrypoint needed in release mode
`entrypointArgs = ["mcp-server"]`, // EntrypointArgs needed in release mode
`"/opt/gh-aw:/opt/gh-aw:ro"`, // gh-aw binary mount
`"/usr/bin/gh:/usr/bin/gh:ro"`, // gh CLI binary mount
`"\${GITHUB_WORKSPACE}:\${GITHUB_WORKSPACE}:rw"`, // workspace mount
`"/tmp/gh-aw:/tmp/gh-aw:rw"`, // temp directory mount
`entrypoint = "/opt/gh-aw/gh-aw"`, // Entrypoint needed in release mode
`entrypointArgs = ["mcp-server", "--actor", "${GITHUB_ACTOR}"]`, // EntrypointArgs needed in release mode with actor flag
`"/opt/gh-aw:/opt/gh-aw:ro"`, // gh-aw binary mount
`"/usr/bin/gh:/usr/bin/gh:ro"`, // gh CLI binary mount
`"\${GITHUB_WORKSPACE}:\${GITHUB_WORKSPACE}:rw"`, // workspace mount
`"/tmp/gh-aw:/tmp/gh-aw:rw"`, // temp directory mount
},
unexpectedContent: []string{
`--cmd`,
Expand All @@ -304,7 +304,7 @@ func TestRenderAgenticWorkflowsMCPConfigTOML(t *testing.T) {
`[mcp_servers.agenticworkflows]`,
tt.expectedContainer,
`args = ["--network", "host", "-w", "${GITHUB_WORKSPACE}"]`, // Network access + working directory
`env_vars = ["DEBUG", "GITHUB_TOKEN"]`,
`env_vars = ["DEBUG", "GITHUB_TOKEN", "GITHUB_ACTOR"]`,
}
expectedContent = append(expectedContent, tt.expectedMounts...)

Expand Down
Loading