Skip to content

Fix slide-deck-maintainer: require explicit safe output tool calls #15200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Feb 12, 2026
Merged

Fix slide-deck-maintainer: require explicit safe output tool calls #15200

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ab2905
Initial plan
Copilot Feb 12, 2026
92f28fb
Fix slide-deck-maintainer: add explicit safe output tool requirements
Copilot Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 46 additions & 10 deletions .github/workflows/slide-deck-maintainer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,9 +226,42 @@ kill $(cat /tmp/server.pid) 2>/dev/null || true
rm -f /tmp/server.pid /tmp/slides-preview.html /tmp/slides-preview-updated.html /tmp/server.log
```

## Step 9: Create Pull Request (if changes made)
## Step 9: Report Your Actions (REQUIRED)

If you made changes to `docs/slides/index.md`, create a pull request with:
**CRITICAL**: You MUST call one of the safe output tools before completing:

### If NO changes were made:

Call the `noop` tool to report completion:

```json
{
"message": "Slide deck maintenance complete - no changes needed",
"details": {
"slides_reviewed": 49,
"layout_issues_found": 0,
"content_errors_found": 0,
"sources_checked": ["code", "docs", "workflows"],
"focus_mode": "${{ inputs.focus }}",
"next_recommended_focus": "feature-deep-dive or area to review next"
}
Comment on lines +239 to +247
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The noop example JSON hard-codes values like slides_reviewed: 49 and zeros, which may be copied verbatim and produce misleading run metadata. Consider using placeholders (e.g., <number> / <string>), or explicitly label these as example values and instruct the agent to replace them with actual counts from the current run.

Copilot uses AI. Check for mistakes.
}
```

**Why this matters**: The `noop` tool records that you completed your work successfully
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines include trailing whitespace at the end of the line. Trailing spaces can cause noisy diffs and may fail markdown linting in some repos; remove the trailing whitespace.

Suggested change
**Why this matters**: The `noop` tool records that you completed your work successfully
**Why this matters**: The `noop` tool records that you completed your work successfully

Copilot uses AI. Check for mistakes.
even though no code changes were made. Without this, the workflow will be marked as failed.

### If changes WERE made:

Proceed to Step 10 to create a pull request.

**Important Note**: Safe output tools (`noop`, `create_pull_request`, etc.) are MCP tools
available through your standard tool calling interface. Call them directly - do NOT try to
Comment on lines +258 to +259
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines include trailing whitespace at the end of the line. Trailing spaces can cause noisy diffs and may fail markdown linting in some repos; remove the trailing whitespace.

Copilot uses AI. Check for mistakes.
invoke them via bash commands, npm scripts, or curl requests.

## Step 10: Create Pull Request (if changes made)

If you made changes to `docs/slides/index.md`, call the `create_pull_request` tool with:

**Title**: `[slides] Update slide deck - [brief description]`

Expand Down Expand Up @@ -257,12 +290,15 @@ ${{ inputs.focus }}

**Labels**: `documentation`, `automated`, `slides`

## Summary
## Completion Checklist

Before finishing, ensure you have:

- [ ] Built and tested slides (or documented why not possible)
- [ ] Scanned repository content for accuracy
- [ ] Detected and documented any layout issues
- [ ] Made changes if needed
- [ ] **Called `noop` OR `create_pull_request`** ← REQUIRED

After completing your work, provide:
- Number of slides reviewed
- Number of layout issues detected and fixed
- Key content updates made
- Source areas scanned (code/workflows/docs)
- PR link (if created)
- Next recommended focus area for the next run
**Remember**: Safe output tools are MCP tools - call them through your tool interface,
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines include trailing whitespace at the end of the line. Trailing spaces can cause noisy diffs and may fail markdown linting in some repos; remove the trailing whitespace.

Suggested change
**Remember**: Safe output tools are MCP tools - call them through your tool interface,
**Remember**: Safe output tools are MCP tools - call them through your tool interface,

Copilot uses AI. Check for mistakes.
not via bash/shell commands.
Loading