Fix secret redaction test expectations for full redaction format#15235
Merged
Fix secret redaction test expectations for full redaction format#15235
Conversation
The test was expecting partial redaction (abc***) but the correct security behavior is full redaction (***REDACTED***) to prevent information disclosure (CWE-200). Updated test to match the secure implementation. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix continuous integration failures
Fix secret redaction test expectations for full redaction format
Feb 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a failing unit test by aligning the expected redaction output with the existing secure redaction behavior (full replacement with a fixed string to avoid prefix disclosure).
Changes:
- Update the
"should redact 6-character secrets"test assertion to expect full redaction (***REDACTED***) instead of partial masking.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A test case in
redact_secrets.test.cjswas failing because it expected partial redaction (abc***) while the implementation correctly uses full redaction (***REDACTED***).Changes
***REDACTED***instead ofabc***The implementation in
redact_secrets.cjswas already correct—this only updates the test to match.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.