Skip to content

Remove unused generateMaxWithRequiredFieldsConfig function#15249

Merged
pelikhan merged 3 commits intomainfrom
copilot/fix-lint-go-workflow-again
Feb 12, 2026
Merged

Remove unused generateMaxWithRequiredFieldsConfig function#15249
pelikhan merged 3 commits intomainfrom
copilot/fix-lint-go-workflow-again

Conversation

Copy link
Contributor

Copilot AI commented Feb 12, 2026

The lint-go workflow was failing with unused linter error for generateMaxWithRequiredFieldsConfig in pkg/workflow/safe_outputs_config_generation_helpers.go.

Changes

The function was intended for safe output configs with required filter fields but was superseded by generateMaxWithDiscussionFieldsConfig which provides the same functionality with additional discussion-specific fields.

Original prompt

Fix the failing GitHub Actions workflow lint-go
Analyze the workflow logs, identify the root cause of the failure, and implement a fix.
Job ID: 63460548483
Job URL: https://github.com/github/gh-aw/actions/runs/21967373108/job/63460548483


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…t-go workflow

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions workflow lint-go Remove unused generateMaxWithRequiredFieldsConfig function Feb 12, 2026
Copilot AI requested a review from pelikhan February 12, 2026 23:14
@pelikhan pelikhan marked this pull request as ready for review February 12, 2026 23:27
Copilot AI review requested due to automatic review settings February 12, 2026 23:27
@pelikhan pelikhan merged commit 0835689 into main Feb 12, 2026
50 checks passed
@pelikhan pelikhan deleted the copilot/fix-lint-go-workflow-again branch February 12, 2026 23:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the unused generateMaxWithRequiredFieldsConfig helper function from pkg/workflow/safe_outputs_config_generation_helpers.go to fix a failing lint-go workflow. The function was added in PR #15240 as part of the allowed-repos feature implementation but was never integrated into the actual config generation logic, as it was superseded by generateMaxWithDiscussionFieldsConfig which provides the same functionality with an additional required_category field for discussion-specific filtering.

Changes:

  • Removed the unused generateMaxWithRequiredFieldsConfig function (lines 63-75) that was flagged by the unused linter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants