Remove unused generateMaxWithRequiredFieldsConfig function#15249
Merged
Remove unused generateMaxWithRequiredFieldsConfig function#15249
Conversation
…t-go workflow Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions workflow lint-go
Remove unused generateMaxWithRequiredFieldsConfig function
Feb 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the unused generateMaxWithRequiredFieldsConfig helper function from pkg/workflow/safe_outputs_config_generation_helpers.go to fix a failing lint-go workflow. The function was added in PR #15240 as part of the allowed-repos feature implementation but was never integrated into the actual config generation logic, as it was superseded by generateMaxWithDiscussionFieldsConfig which provides the same functionality with an additional required_category field for discussion-specific filtering.
Changes:
- Removed the unused
generateMaxWithRequiredFieldsConfigfunction (lines 63-75) that was flagged by theunusedlinter
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lint-goworkflow was failing withunusedlinter error forgenerateMaxWithRequiredFieldsConfiginpkg/workflow/safe_outputs_config_generation_helpers.go.Changes
generateMaxWithRequiredFieldsConfighelper function (added in Add allowed-repos support to add-labels and close-issue safe outputs #15240 but never integrated into config generation logic)The function was intended for safe output configs with required filter fields but was superseded by
generateMaxWithDiscussionFieldsConfigwhich provides the same functionality with additional discussion-specific fields.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.