Fix TypeScript strict null check error in create_issue.cjs

[Copilot]

TypeScript type check was failing in the js workflow at line 488 of create_issue.cjs. The function normalizeTemporaryId() expects a string parameter, but received temporaryId with type string | null from getOrGenerateTemporaryId().

Changes

• Wrapped temporaryId with String() before passing to normalizeTemporaryId()
• Extracted normalization to intermediate variable for clarity

// Before
temporaryIdMap.set(normalizeTemporaryId(temporaryId), { repo: qualifiedItemRepo, number: issue.number });

// After
const normalizedTempId = normalizeTemporaryId(String(temporaryId));
temporaryIdMap.set(normalizedTempId, { repo: qualifiedItemRepo, number: issue.number });

While the JSDoc type cast /** @type {string} */ and early return on error guarantee temporaryId is non-null at runtime, TypeScript's strict null checking (strictNullChecks: true) requires explicit type narrowing. The String() wrapper satisfies this without changing runtime behavior since normalizeTemporaryId() already performs string coercion internally.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://api.github.com/repos/github/gh-aw/contents/.github%2Fworkflows%2Faudit-workflows.md
  • Triggering command: /opt/hostedtoolcache/node/24.13.0/x64/bin/node /opt/hostedtoolcache/node/24.13.0/x64/bin/node --conditions node --conditions development --experimental-import-meta-resolve --require /home/REDACTED/work/gh-aw/gh-aw/actions/setup/js/node_modules/vitest/suppress-warnings.cjs /home/REDACTED/work/gh-aw/gh-aw/actions/setup/js/node_modules/vitest/dist/workers/forks.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

Fix the failing GitHub Actions workflow js
Analyze the workflow logs, identify the root cause of the failure, and implement a fix.
Job ID: 63630858069
Job URL: https://github.com/github/gh-aw/actions/runs/22021316704/job/63630858069

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

Pull request overview

This PR fixes a TypeScript strict null check error in create_issue.cjs by wrapping the temporaryId variable with String() before passing it to normalizeTemporaryId(). While TypeScript's control flow analysis should recognize that temporaryId is non-null after the early return check and JSDoc type cast, this fix ensures the code passes strict null checking.

Changes:

• Added String() wrapper around temporaryId when calling normalizeTemporaryId() to satisfy TypeScript's strict null checking
• Extracted normalization to intermediate variable for clarity
• Added clarifying comment explaining the null-safety guarantee

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The String() wrapper is redundant because normalizeTemporaryId() already calls String() internally on its parameter (see temporary_id.cjs line 53). This means the string conversion happens twice.

While this doesn't change runtime behavior, it adds unnecessary code. Since the temporaryId variable at line 321 already has a JSDoc type cast to string, and there's an early return if tempIdResult.error is truthy (lines 313-318), the TypeScript type checker should recognize that temporaryId is non-null at this point.

If TypeScript's control flow analysis isn't recognizing the JSDoc cast, a more idiomatic solution would be to add a runtime check (e.g., if (!temporaryId) throw new Error(...)) or use a non-null assertion if you're confident about the guarantee. The redundant String() call works but masks the underlying type narrowing issue.

Suggested change

	const normalizedTempId = normalizeTemporaryId(String(temporaryId));
	const normalizedTempId = normalizeTemporaryId(temporaryId);