Move if-body setting to submit-pull-request-review#15793
Merged
pelikhan merged 1 commit intogithub:mainfrom Feb 14, 2026
Merged
Move if-body setting to submit-pull-request-review#15793pelikhan merged 1 commit intogithub:mainfrom
pelikhan merged 1 commit intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects the placement of the footer configuration setting by moving it from create-pull-request-review-comment to submit-pull-request-review. The issue was that footers appear in the PR review body (controlled by submit-pull-request-review), not in individual review comments (created by create-pull-request-review-comment). This change ensures the configuration setting is placed where it actually has an effect.
Changes:
- Moved
footerfield fromCreatePullRequestReviewCommentsConfigtoSubmitPullRequestReviewConfigwith string type support for "always", "none", and "if-body" modes - Updated JavaScript handlers to read footer configuration from
submit_pull_request_reviewinstead ofcreate_pull_request_review_comment - Added comprehensive test coverage for the new configuration location and the
getEffectiveFooterStringhelper function - Updated documentation, schema, and TypeScript types to reflect the corrected configuration location
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/submit_pr_review.go | Changed Footer field from *bool to *string and added parsing logic for string values ("always", "none", "if-body") with backward compatibility for boolean values |
| pkg/workflow/create_pr_review_comment.go | Removed Footer field and its parsing logic from CreatePullRequestReviewCommentsConfig |
| pkg/workflow/compiler_safe_outputs_config.go | Added getEffectiveFooterString helper function and updated handler registry to use it for submit_pull_request_review |
| pkg/workflow/submit_pr_review_footer_test.go | Renamed tests, added tests for getEffectiveFooterString, and updated all test cases to reference submit-pull-request-review instead of create-pull-request-review-comment |
| pkg/parser/schemas/main_workflow_schema.json | Moved footer field schema definition from create-pull-request-review-comment to submit-pull-request-review with oneOf support for boolean and string enum values |
| docs/src/content/docs/reference/safe-outputs-specification.md | Added note about footer control on submit-pull-request-review |
| docs/src/content/docs/reference/footers.md | Updated documentation to clarify that footer control applies to PR review body via submit-pull-request-review |
| .github/aw/github-agentic-workflows.md | Moved footer control documentation from create-pull-request-review-comment to submit-pull-request-review |
| actions/setup/js/types/safe-outputs-config.d.ts | Added SubmitPullRequestReviewConfig interface with footer field support |
| actions/setup/js/safe_output_unified_handler_manager.cjs | Updated to read footer config from submit_pull_request_review only, removing fallback to create_pull_request_review_comment |
| actions/setup/js/safe_output_handler_manager.cjs | Same update as unified handler manager |
| actions/setup/js/pr_review_buffer.cjs | Updated comments to reflect that submit-pull-request-review.footer controls the review body footer |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Add more tests |
This was referenced Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15783