Skip to content

Comments

Move if-body setting to submit-pull-request-review#15793

Merged
pelikhan merged 1 commit intogithub:mainfrom
strawgate:move-if-body-to-submission
Feb 14, 2026
Merged

Move if-body setting to submit-pull-request-review#15793
pelikhan merged 1 commit intogithub:mainfrom
strawgate:move-if-body-to-submission

Conversation

@strawgate
Copy link
Contributor

Fixes #15783

Copilot AI review requested due to automatic review settings February 14, 2026 21:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects the placement of the footer configuration setting by moving it from create-pull-request-review-comment to submit-pull-request-review. The issue was that footers appear in the PR review body (controlled by submit-pull-request-review), not in individual review comments (created by create-pull-request-review-comment). This change ensures the configuration setting is placed where it actually has an effect.

Changes:

  • Moved footer field from CreatePullRequestReviewCommentsConfig to SubmitPullRequestReviewConfig with string type support for "always", "none", and "if-body" modes
  • Updated JavaScript handlers to read footer configuration from submit_pull_request_review instead of create_pull_request_review_comment
  • Added comprehensive test coverage for the new configuration location and the getEffectiveFooterString helper function
  • Updated documentation, schema, and TypeScript types to reflect the corrected configuration location

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/workflow/submit_pr_review.go Changed Footer field from *bool to *string and added parsing logic for string values ("always", "none", "if-body") with backward compatibility for boolean values
pkg/workflow/create_pr_review_comment.go Removed Footer field and its parsing logic from CreatePullRequestReviewCommentsConfig
pkg/workflow/compiler_safe_outputs_config.go Added getEffectiveFooterString helper function and updated handler registry to use it for submit_pull_request_review
pkg/workflow/submit_pr_review_footer_test.go Renamed tests, added tests for getEffectiveFooterString, and updated all test cases to reference submit-pull-request-review instead of create-pull-request-review-comment
pkg/parser/schemas/main_workflow_schema.json Moved footer field schema definition from create-pull-request-review-comment to submit-pull-request-review with oneOf support for boolean and string enum values
docs/src/content/docs/reference/safe-outputs-specification.md Added note about footer control on submit-pull-request-review
docs/src/content/docs/reference/footers.md Updated documentation to clarify that footer control applies to PR review body via submit-pull-request-review
.github/aw/github-agentic-workflows.md Moved footer control documentation from create-pull-request-review-comment to submit-pull-request-review
actions/setup/js/types/safe-outputs-config.d.ts Added SubmitPullRequestReviewConfig interface with footer field support
actions/setup/js/safe_output_unified_handler_manager.cjs Updated to read footer config from submit_pull_request_review only, removing fallback to create_pull_request_review_comment
actions/setup/js/safe_output_handler_manager.cjs Same update as unified handler manager
actions/setup/js/pr_review_buffer.cjs Updated comments to reflect that submit-pull-request-review.footer controls the review body footer

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pelikhan
Copy link
Contributor

Add more tests

@pelikhan pelikhan merged commit 90dd7cc into github:main Feb 14, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Footer control should be on PR Review Submission not on comments

2 participants