Decouple ai-reaction emoji from status comments [BREAKING]#15856
Decouple ai-reaction emoji from status comments [BREAKING]#15856
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot remove legacy bundling of reaction and status comment. Both have to be enabled separately. |
| @@ -0,0 +1,112 @@ | |||
| --- | |||
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done! Removed the legacy bundling in commit 74837ae. Both on:
reaction: eyes # Only adds reaction
status-comment: true # Must be explicit for status commentsBreaking change: Existing workflows with only |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot review and clean, simplify, tidy changes |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Reviewed and cleaned up in commits 59e7eaf and 1e38c60: Simplified:
Changes: 4 Go files, 1 schema file, 2 test files (8 total source files + auto-recompiled lock files) All tests passing ✅ |
|
🧪 Smoke Project is now testing project operations... |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
🧪 Smoke Temporary ID is now testing temporary ID functionality... |
|
❌ Smoke Copilot SDK failed. Please review the logs for details. |
|
✅ Smoke Temporary ID completed successfully. Temporary ID validation passed. |
Agent Container Tool Check ✅
Result: 12/12 tools available ✅ All required development tools are accessible in the agent container environment.
|
|
✅ Smoke Project completed successfully. All project operations validated. |
There was a problem hiding this comment.
Pull request overview
This PR implements a breaking change that decouples the ai-reaction emoji from status comments. Previously, setting reaction: eyes automatically created status comments (started/completed). Now, both features must be explicitly enabled independently.
Changes:
- Added
StatusComment *boolfield to enable/disable status comments independently of reactions - Updated compiler logic to check
StatusCommentfield instead ofAIReactionfor comment generation - Migrated 7 smoke test workflows to explicitly enable
status-comment: true - Added comprehensive test coverage with 6 unit tests and 3 integration tests
Reviewed changes
Copilot reviewed 163 out of 163 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/compiler_types.go |
Added StatusComment *bool field to WorkflowData |
pkg/workflow/compiler_safe_outputs.go |
Parse status-comment from on section with boolean validation |
pkg/workflow/compiler_activation_jobs.go |
Changed condition from AIReaction check to StatusComment pointer check |
pkg/workflow/notify_comment.go |
Guard conclusion update step with StatusComment check, updated docs |
pkg/workflow/notify_comment_test.go |
Updated 8 tests to reflect breaking change, added expectUpdateStep flag |
pkg/workflow/status_comment_decoupling_test.go |
New file with 6 test cases covering all combinations |
pkg/workflow/test_data/test-status-comment-decoupling.md |
Test workflow data file |
pkg/parser/schemas/main_workflow_schema.json |
Added status-comment boolean field to schema |
| 7 smoke workflow files | All migrated with status-comment: true |
| 154 lock files | Automatically regenerated, removed status comment steps where appropriate |
.changeset/minor-decouple-status-comment.md |
Changeset describing the breaking change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎪 The Copilot circus is in town! 🎪 Just swung by to say the smoke test agent is performing its digital gymnastics in run §22037471608. Testing all the bells and whistles - from MCP servers to Playwright acrobatics! Back flips away ✨
|
Smoke Test ResultsPRs Reviewed:
Tests:
Overall: PASS (10/11) cc
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Reviewed the decoupling of ai-reaction and status-comment. The changes cleanly separate these concerns while maintaining backward compatibility where possible. Good work on the breaking change documentation!
📰 BREAKING: Report filed by Smoke Copilot for issue #15856
| if statusCommentBool, ok := statusCommentValue.(bool); ok { | ||
| workflowData.StatusComment = &statusCommentBool | ||
| compilerSafeOutputsLog.Printf("status-comment set to: %v", statusCommentBool) | ||
| } else { |
There was a problem hiding this comment.
Nice separation of concerns! Breaking status-comment into its own flag gives users more control.
| "gh-aw": minor | ||
| --- | ||
|
|
||
| Decouple the status comment from the ordinary ai-reaction emoji so they must each be enabled explicitly (e.g., add `status-comment: true` if you still need the started/completed comment). This fixes github/gh-aw#15831. |
There was a problem hiding this comment.
Clear changeset - this BREAKING change is well documented with migration path.
|
Smoke test results:
|
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
There was a problem hiding this comment.
💥 Automated smoke test review - all systems nominal!
💥 [THE END] — Illustrated by Smoke Claude for issue #15856
✅ BREAKING CHANGE: Reaction and Status Comments Now Independent
Fully decoupled
reactionandstatus-comment- both must be explicitly enabled.Breaking Change
New behavior:
To get both:
Implementation
Core Changes (4 Go files, simplified):
compiler_types.go: AddedStatusComment *boolfieldcompiler_safe_outputs.go: Parsestatus-commentfromonsectioncompiler_activation_jobs.go: Direct pointer checkif data.StatusComment != nil && *data.StatusCommentnotify_comment.go: Direct pointer check, removed unused variables, updated doc commentSchema: Added
status-commentfield validationTesting (simplified):
Files Changed
Source code (8 files):
pkg/workflow/compiler_types.gopkg/workflow/compiler_safe_outputs.gopkg/workflow/compiler_activation_jobs.gopkg/workflow/notify_comment.gopkg/workflow/notify_comment_test.gopkg/workflow/status_comment_decoupling_test.go(new)pkg/workflow/test_data/test-status-comment-decoupling.md(new)pkg/parser/schemas/main_workflow_schema.jsonWorkflows migrated (7 files):
.github/workflows/smoke-copilot.md- Addedstatus-comment: true.github/workflows/smoke-claude.md- Addedstatus-comment: true.github/workflows/smoke-codex.md- Addedstatus-comment: true.github/workflows/smoke-copilot-sdk.md- Addedstatus-comment: true.github/workflows/smoke-opencode.md- Addedstatus-comment: true.github/workflows/smoke-project.md- Addedstatus-comment: true.github/workflows/smoke-temporary-id.md- Addedstatus-comment: trueLock files: Automatically recompiled (all 154 workflows)
Validation
✅ All checks passing:
make fmt✅make lint✅Migration Required
reaction: eyesmust addstatus-comment: trueto preserve status comments.Example: All 7 smoke workflows have been updated in this PR to demonstrate the migration.
Original prompt
ai-reactionemoji from status comment #15831💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
Changeset
status-comment: truewhen you still want the started/completed comment).✨ PR Review Safe Output Test - Run 22029968048