Merged
Conversation
Modernize and clean test file for is_truthy: - Remove weird parenthesis patterns and comma operators - Improve test descriptions with context - Properly structure assertions (one assertion per line) - Maintain 10 comprehensive test cases covering all edge cases Test improvements: - All 10 tests passing ✓ - Better readability and maintainability - No logic changes, only code quality improvements Validation checks passed: ✓ Formatting: npm run format:cjs ✓ Linting: npm run lint:cjs ✓ Type checking: npm run typecheck ✓ Tests: npm run test:js -- is_truthy.test.cjs (10/10 passed) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
pelikhan
approved these changes
Feb 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes actions/setup/js/is_truthy.test.cjs to make the isTruthy unit tests clearer and easier to maintain, without changing test coverage or behavior.
Changes:
- Replaced boolean obfuscations (
!0/!1) with explicittrue/falseliterals. - Removed comma-operator patterns and reformatted tests so each assertion is on its own line.
- Improved test names to better describe intent (e.g., noting case-insensitive behavior).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernized and cleaned the test file for
is_truthy.cjsto improve code quality and readability.Changes Made
Code Quality Improvements
!1and!0to properfalseandtrueliterals for clarityTest Coverage
Execution Context
Validation Results
All validation checks passed successfully:
npm run format:cjsnpm run lint:cjsnpm run typechecknpm run test:js -- is_truthy.test.cjsBefore/After Example
Before (obfuscated and hard to read):
After (clean and readable):
Impact