Extract shared helper for close-older entity flows

[Copilot]

closeOlderIssues and closeOlderDiscussions contained ~140 lines of duplicate control flow (search → limit → iterate → close → error handling). Only entity-specific API calls differed.

Changes

• New shared helper close_older_entities.cjs

  • Orchestrates complete flow: search, logging, MAX_CLOSE_COUNT limit, rate-limiting, error recovery
  • Entity-agnostic via callback configuration pattern (similar to expired_entity_main_flow.cjs)

• Refactored callers to configuration-based invocation

  • close_older_issues.cjs: 308 → 222 lines (-28%)
  • close_older_discussions.cjs: 310 → 240 lines (-23%)
  • All exports and behavior unchanged

Before:

async function closeOlderIssues(...) {
  core.info("Starting operation...");
  const older = await searchOlderIssues(...);
  if (older.length === 0) return [];
  
  const toClose = older.slice(0, MAX_CLOSE_COUNT);
  // ... 100+ more lines of iteration, error handling, logging
}

After:

async function closeOlderIssues(...) {
  return closeOlderEntities(..., {
    entityType: "issue",
    searchOlderEntities: searchOlderIssues,
    addComment: addIssueComment,
    closeEntity: closeIssueAsNotPlanned,
    delayMs: API_DELAY_MS,
    getEntityId: entity => entity.number,
    getEntityUrl: entity => entity.html_url,
  });
}

Files

• actions/setup/js/close_older_entities.cjs (new, 169 lines)
• actions/setup/js/close_older_entities.test.cjs (new, 11 tests)
• actions/setup/js/close_older_issues.cjs (refactored)
• actions/setup/js/close_older_discussions.cjs (refactored)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://api.github.com/repos/github/gh-aw/contents/.github%2Fworkflows%2Faudit-workflows.md
  • Triggering command: /opt/hostedtoolcache/node/24.13.0/x64/bin/node /opt/hostedtoolcache/node/24.13.0/x64/bin/node --conditions node --conditions development --experimental-import-meta-resolve --require /home/REDACTED/work/gh-aw/gh-aw/actions/setup/js/node_modules/vitest/suppress-warnings.cjs /home/REDACTED/work/gh-aw/gh-aw/actions/setup/js/node_modules/vitest/dist/workers/forks.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Duplicate Code: closeOlder* issue/discussion cleanup flow</issue_title>
<issue_description># 🔍 Duplicate Code Detected: Close Older Entities Flow

Analysis of commit 56e1ce9

Assignee: @copilot

Summary

The closeOlderIssues and closeOlderDiscussions functions implement nearly identical control flow for searching older entities, logging results, rate-limiting, and iterating to close items. The bodies are structurally the same with only entity-specific naming and API calls changed.

Duplication Details

Pattern: Close older entities with shared flow

• Severity: Medium
• Occurrences: 2
• Locations:
  • actions/setup/js/close_older_issues.cjs:195
  • actions/setup/js/close_older_discussions.cjs:199
• Code Sample:

async function closeOlderIssues(github, owner, repo, workflowId, newIssue, workflowName, runUrl) {
  core.info("=".repeat(70));
  core.info("Starting closeOlderIssues operation");
  core.info("=".repeat(70));
  ...
  const olderIssues = await searchOlderIssues(...);
  if (olderIssues.length === 0) {
    core.info("✓ No older issues found to close - operation complete");
    core.info("=".repeat(70));
    return [];
  }
  ...
  for (let i = 0; i < issuesToClose.length; i++) {
    const issue = issuesToClose[i];
    ...
    await addIssueComment(...);
    await closeIssueAsNotPlanned(...);
    ...
    if (i < issuesToClose.length - 1) {
      core.info(`Waiting \$\{API_DELAY_MS}ms before processing next issue to avoid rate limiting...`);
      await delay(API_DELAY_MS);
    }
  }
  ...
}

async function closeOlderDiscussions(github, owner, repo, workflowId, categoryId, newDiscussion, workflowName, runUrl) {
  core.info("=".repeat(70));
  core.info("Starting closeOlderDiscussions operation");
  core.info("=".repeat(70));
  ...
  const olderDiscussions = await searchOlderDiscussions(...);
  if (olderDiscussions.length === 0) {
    core.info("✓ No older discussions found to close - operation complete");
    core.info("=".repeat(70));
    return [];
  }
  ...
  for (let i = 0; i < discussionsToClose.length; i++) {
    const discussion = discussionsToClose[i];
    ...
    await addDiscussionComment(...);
    await closeDiscussionAsOutdated(...);
    ...
    if (i < discussionsToClose.length - 1) {
      core.info(`Waiting \$\{GRAPHQL_DELAY_MS}ms before processing next discussion to avoid rate limiting...`);
      await delay(GRAPHQL_DELAY_MS);
    }
  }
  ...
}

Impact Analysis

• Maintainability: Changes to logging, rate limit handling, or summary output must be duplicated and kept in sync.
• Bug Risk: Divergence risk if one flow receives a fix or enhancement but the other does not.
• Code Bloat: Large, repetitive bodies across two files.

Refactoring Recommendations

1. Extract shared flow to a helper

   • Extract to: actions/setup/js/expired_entity_main_flow.cjs or a new actions/setup/js/close_older_entities.cjs
   • Estimated effort: Medium (2-4 hours)
   • Benefits: Single flow for search/limit/log/close logic with entity-specific callbacks

2. Parameterize entity-specific actions

   • Accept callbacks for search, comment, close, and delay duration
   • Benefits: Reduce duplication while preserving behavioral differences

Implementation Checklist

• Review duplication findings
• Prioritize refactoring tasks
• Create refactoring plan
• Implement changes
• Update tests
• Verify no functionality broken

Analysis Metadata

• Analyzed Files: 2
• Detection Method: Serena semantic code analysis
• Commit: 56e1ce9
• Analysis Date: 2026-02-15

Generated by Duplicate Code Detector

Comments on the Issue (you are @copilot in this section)

• Fixes Duplicate Code: closeOlder* issue/discussion cleanup flow #15861

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

Pull request overview

Extracts the duplicated “search → limit → iterate → comment → close → log/errors” flow from closeOlderIssues and closeOlderDiscussions into a shared helper, keeping entity-specific behavior behind a configuration object.

Changes:

• Added closeOlderEntities() helper to centralize close-older control flow with callback-based customization.
• Refactored issue + discussion flows to call the shared helper (reducing duplicate logic and consolidating logging/error handling).
• Added a new unit test suite for the shared helper.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
actions/setup/js/close_older_entities.cjs	New shared orchestration helper for closing older entities via config callbacks.
actions/setup/js/close_older_entities.test.cjs	New Vitest suite validating the shared helper behavior (limits, errors, args, etc.).
actions/setup/js/close_older_issues.cjs	Refactors issues flow to use shared helper and maps helper result back to issue return type.
actions/setup/js/close_older_discussions.cjs	Refactors discussions flow to use shared helper; adjusts GraphQL helpers to match shared callback signature.

Comments suppressed due to low confidence (1)

actions/setup/js/close_older_entities.cjs:85

• closeOlderEntities logs entity.number and entity.title directly, but those fields are not part of the EntityCloseConfig contract (only getEntityId/getEntityUrl are). If you intend this to be reusable, add config callbacks for display label/number/title (or a formatEntityForLog hook) so the helper doesn’t silently depend on a specific object shape.

  core.info(`Found ${olderEntities.length} older ${config.entityType}(s) matching the criteria`);
  for (const entity of olderEntities) {
    core.info(`  - ${config.entityType.charAt(0).toUpperCase() + config.entityType.slice(1)} #${entity.number}: ${entity.title}`);
    if (entity.labels) {
      core.info(`    Labels: ${entity.labels.map(l => l.name).join(", ") || "(none)"}`);
    }
    core.info(`    URL: ${config.getEntityUrl(entity)}`);
  }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

getErrorMessage is imported but never used in this refactored file (error formatting now happens inside close_older_entities.cjs). Please remove the unused require to avoid dead code and keep lint/ts-check clean.

Suggested change

const { getErrorMessage } = require("./error_helpers.cjs");

[Copilot]

This mapping now falls back to an empty string for html_url, but the function’s return contract is html_url: string and callers typically expect a valid URL. Prefer returning item.html_url directly (and/or asserting it’s present) so missing URLs fail fast instead of silently returning invalid links.

Suggested change

	html_url: item.html_url || "",
	html_url: item.html_url,

[Copilot]

This mapping now falls back to an empty string for url, which can silently produce invalid links while the function’s return type indicates url: string. Prefer returning item.url directly (and/or validating it’s present) so unexpected missing URLs don’t get masked.

Suggested change

	url: item.url || "",
	url: item.url,

[Copilot]

The helper claims to be entity-agnostic, but it hard-requires newEntity.number (and passes it to searchOlderEntities) rather than using a config callback. Consider adding something like getNewEntityNumber (or reusing getEntityId semantics) so the helper doesn’t bake in an assumption that every entity has a numeric number field.

This issue also appears on line 78 of the same file.

[Copilot]

This test relies on wall-clock timing (Date.now() + a real setTimeout) which can be flaky under CI load and slows the suite unnecessarily. Prefer using fake timers (e.g., advance timers and assert setTimeout was scheduled) or spying on setTimeout to make the test deterministic.

Suggested change

	const start = Date.now();
	await delay(50);
	const elapsed = Date.now() - start;
	expect(elapsed).toBeGreaterThanOrEqual(45); // Allow some tolerance
	vi.useFakeTimers();
	const promise = delay(50);
	await vi.advanceTimersByTimeAsync(50);
	await expect(promise).resolves.toBeUndefined();
	vi.useRealTimers();